Re: [quicwg/base-drafts] Replace the RequireInsertCount decoding algorithm (#2379)

Bence Béky <notifications@github.com> Wed, 30 January 2019 02:37 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 918BE1310FA for <quic-issues@ietfa.amsl.com>; Tue, 29 Jan 2019 18:37:09 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -11.574
X-Spam-Level:
X-Spam-Status: No, score=-11.574 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FROM_EXCESS_BASE64=0.979, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jxZxBZxIxusy for <quic-issues@ietfa.amsl.com>; Tue, 29 Jan 2019 18:37:08 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3EA071310FC for <quic-issues@ietf.org>; Tue, 29 Jan 2019 18:37:08 -0800 (PST)
Date: Tue, 29 Jan 2019 18:37:07 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1548815827; bh=Kptgy4pLkdTU8bHOjyRwDeLbES/c+cO0zHFfRdmWZ+s=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=DX/j86JKedENKhSJiHaesiSD6pQnpjqxP9aRIGk6b5+8xSKJbVHS73mtXqsQskfw+ 0zzxoyo05pmnMPh61xE0ywIAGUKM1AjfvDGk6N0MlJWlSNoTnpiMiwE9xmH+GSCgSm xTu5tD2guvqQlyt4PDBXa8WFNuzUdcn7K77IrHrk=
From: Bence Béky <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab9d4d8d8d0f0405b0fddf16ffc3a3e0c7b566c96492cf000000011868cfd392a169ce180fea0e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2379/c458789140@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2379@github.com>
References: <quicwg/base-drafts/pull/2379@github.com>
Subject: Re: [quicwg/base-drafts] Replace the RequireInsertCount decoding algorithm (#2379)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c510dd3946af_18a43fd64f6d45c42347d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: bencebeky
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/UyfhMUVH4SSMjGPQXjhl1XmuzDg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Jan 2019 02:37:10 -0000

I agree that an error should be generated in that case and I support adding the check to the code.  Since "the decoder reconstructs the Required Insert Count using the following algorithm", and not "this is an example algorithm to reconstruct the Required Insert Count", I consider the code to be normative, so I do not think it is necessary to spell this out in text.

BTW I'm not in love with this algorithm, mostly because it is longer and more complicated than the original without improving on clarity, but I can live with it.  I still think the one I proposed at #2248 would be the least error-prone (most implementers presumably don't care about how the algorithm works, they just copy it line by line, so the fewer lines, the better), but whatever is in the draft currently, or even the one proposed here, is just fine with me after all.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2379#issuecomment-458789140