Re: [quicwg/base-drafts] Close connection if peer becomes unreachable (#2406)

Kazuho Oku <notifications@github.com> Mon, 04 February 2019 14:29 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 61465127B4C for <quic-issues@ietfa.amsl.com>; Mon, 4 Feb 2019 06:29:10 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -11.149
X-Spam-Level:
X-Spam-Status: No, score=-11.149 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6PVjSnc5Er6M for <quic-issues@ietfa.amsl.com>; Mon, 4 Feb 2019 06:29:09 -0800 (PST)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E206012D4EF for <quic-issues@ietf.org>; Mon, 4 Feb 2019 06:29:08 -0800 (PST)
Date: Mon, 04 Feb 2019 06:29:08 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549290548; bh=gq7VSES+HDwGdfT/t9o1SDfZMj1w/vqtqCgklV5TxOM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=YQDxW3btJmPj6QeFskQM2i9YGVUObsXGtGIYNAykXuwKHDz795AjAxXgI3d6wnrWz Tk6UWBj1gn3W2+bAw7GMIPmlXNOoYQr6nJ5+eOPtq6xp4LQfZK603UdqBFTTvmJhrA UuIKq4Kren2TALeT3VJMVBzNfIwxCQtYd9tSJPng=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab46ed5bbd8a3127260c2c71567f47e9f7c1f0c65992cf0000000118700e3492a169ce1836a69f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2406/review/199611636@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2406@github.com>
References: <quicwg/base-drafts/pull/2406@github.com>
Subject: Re: [quicwg/base-drafts] Close connection if peer becomes unreachable (#2406)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c584c3414ec6_22d03fc5a28d45bc452ce"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/UygjVOQ5QLNd72A0V8cYqK2X-C8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Feb 2019 14:29:10 -0000

kazuho commented on this pull request.



> @@ -1862,6 +1862,11 @@ NAT rebinding is not connection migration as defined in this section, though an
 endpoint SHOULD perform path validation ({{migrate-validate}}) if it detects a
 change in the IP address of its peer.
 
+When a client finds the server unreachable over any path, the client might close
+its connection to the server (see {{termination}}).  A client capable of
+connection migration MAY wait for new paths to become available before declaring
+the server unreachable.

I think it might make sense to use "endpoint" rather than "client" and "server", because IIUC that's how we talk about connection migration.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2406#pullrequestreview-199611636