Re: [quicwg/base-drafts] Rewrite text about Version Negotiation (#1039)
martinduke <notifications@github.com> Tue, 16 January 2018 06:28 UTC
Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3D84E126BF0 for <quic-issues@ietfa.amsl.com>; Mon, 15 Jan 2018 22:28:41 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.03
X-Spam-Level:
X-Spam-Status: No, score=-2.03 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GFadQ1T_U4ql for <quic-issues@ietfa.amsl.com>; Mon, 15 Jan 2018 22:28:40 -0800 (PST)
Received: from o11.sgmail.github.com (o11.sgmail.github.com [167.89.101.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E9CD7124D68 for <quic-issues@ietf.org>; Mon, 15 Jan 2018 22:28:39 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=SnZadLThx8ZUY2BpLRlQycHkdPM=; b=bDYniOktyibTy5SN 3g/jzR7PscGE8bfCK0Ao634mevzEY88q5vgLvUB1ETQEoW5BOA7K8OA1ggt7Gjxq abyQkmgp4WrXYV1rNH6U7ZAyVE9No1Z/kQZgOvFuenYRKNwyCDwgdT11TTu55EUc qMSqOK7OAOxmrSrpYsXFletAnIU=
Received: by filter0590p1mdw1.sendgrid.net with SMTP id filter0590p1mdw1-605-5A5D9B97-3 2018-01-16 06:28:39.163127823 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [192.30.253.16]) by ismtpd0018p1iad2.sendgrid.net (SG) with ESMTP id BNixBg4aQ9qUs7p2_Dpoqg for <quic-issues@ietf.org>; Tue, 16 Jan 2018 06:28:38.949 +0000 (UTC)
Date: Tue, 16 Jan 2018 06:28:39 +0000
From: martinduke <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab04eaa1b3cf2b04a93d8ef3c0792b17479b57f32492cf0000000116755d9692a169ce1115d834@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1039/review/88994813@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1039@github.com>
References: <quicwg/base-drafts/pull/1039@github.com>
Subject: Re: [quicwg/base-drafts] Rewrite text about Version Negotiation (#1039)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5a5d9b96dbadc_6bd03feb0ff48f2812202c6"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinduke
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1FS+GW/5fTxvEj2iNEodAbsDbdDMT3z9s7A5 JXxAzIEjiMpbt0EIcYyWfIEsGKbg1el+oJdBShXtqpdEpejtER5VZzcTsoynau0OueYrhLmhDjOUOP NPFW0QJXDDWhb/bU/u94eWa5JirRbjobN5tA1bfVpzbtUroXo34B2CRkTQ==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/V3nB1Ra4Cj2dXntOjoI7HLX5yiQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Jan 2018 06:28:41 -0000
martinduke commented on this pull request. > +Clients SHOULD discard any packet that cannot be associated with an existing +connection. Discarded packets MAY be logged for diagnostic or security +purposes. + +If a server receives a packet not associated with an existing connection, it +executes the following steps, in order: + +1. The server MUST check if the packet uses a short form header, or is not +long enough for the size required for the first packet of any QUIC version +that the server supports. See {{packet-size}} for the definition of packet size +and the minimum size of the first packet in this version of QUIC. If either +condition is true, the packet cannot create a new connection. In this case, the +server MUST either buffer the packet (see {{handshake-buffer}}), send a +stateless reset ({{stateless-reset}}), or silently drop it. + +2. Otherwise, the server checks the version field in the long header. If the I actually implemented this in the order listed. For writing this, I found other arrangements to have more cumbersome conditions to express in English: 1) if (long header) && (big enough) && (version not OK) send VN 2) if (long header) && (big enough) && (version OK) - i.e. I have to write out the first two conditions twice consecutively, or nest the paragraphs somehow. deliver payload to TLS, etc. 3) Drop/Buffer but obviously this is a purely wordsmithing concern. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1039#discussion_r161669013
- [quicwg/base-drafts] Rewrite text about Version N… martinduke
- Re: [quicwg/base-drafts] Rewrite text about Versi… Martin Thomson
- Re: [quicwg/base-drafts] Rewrite text about Versi… Martin Thomson
- Re: [quicwg/base-drafts] Rewrite text about Versi… martinduke
- Re: [quicwg/base-drafts] Rewrite text about Versi… MikkelFJ
- Re: [quicwg/base-drafts] Rewrite text about Versi… martinduke
- Re: [quicwg/base-drafts] Rewrite text about Versi… Martin Thomson
- Re: [quicwg/base-drafts] Rewrite text about Versi… martinduke
- Re: [quicwg/base-drafts] Rewrite text about Versi… martinduke
- Re: [quicwg/base-drafts] Rewrite text about Versi… martinduke
- Re: [quicwg/base-drafts] Rewrite text about Versi… Martin Thomson
- Re: [quicwg/base-drafts] Rewrite text about Versi… MikkelFJ
- Re: [quicwg/base-drafts] Rewrite text about Versi… ianswett
- Re: [quicwg/base-drafts] Rewrite text about Versi… Martin Thomson
- Re: [quicwg/base-drafts] Rewrite text about Versi… martinduke
- Re: [quicwg/base-drafts] Rewrite text about Versi… ianswett
- Re: [quicwg/base-drafts] Rewrite text about Versi… Martin Thomson
- Re: [quicwg/base-drafts] Rewrite text about Versi… MikkelFJ
- Re: [quicwg/base-drafts] Rewrite text about Versi… Mike Bishop
- Re: [quicwg/base-drafts] Rewrite text about Versi… MikkelFJ
- Re: [quicwg/base-drafts] Rewrite text about Versi… Martin Thomson
- Re: [quicwg/base-drafts] Rewrite text about Versi… Martin Thomson
- Re: [quicwg/base-drafts] Rewrite text about Versi… Martin Thomson
- Re: [quicwg/base-drafts] Rewrite text about Versi… Martin Thomson
- Re: [quicwg/base-drafts] Rewrite text about Versi… martinduke
- Re: [quicwg/base-drafts] Rewrite text about Versi… martinduke
- Re: [quicwg/base-drafts] Rewrite text about Versi… martinduke
- Re: [quicwg/base-drafts] Rewrite text about Versi… martinduke
- Re: [quicwg/base-drafts] Rewrite text about Versi… martinduke
- Re: [quicwg/base-drafts] Rewrite text about Versi… martinduke
- Re: [quicwg/base-drafts] Rewrite text about Versi… Martin Thomson
- Re: [quicwg/base-drafts] Rewrite text about Versi… Nick Banks
- Re: [quicwg/base-drafts] Rewrite text about Versi… MikkelFJ
- Re: [quicwg/base-drafts] Rewrite text about Versi… martinduke
- Re: [quicwg/base-drafts] Rewrite text about Versi… MikkelFJ
- Re: [quicwg/base-drafts] Rewrite text about Versi… MikkelFJ
- Re: [quicwg/base-drafts] Rewrite text about Versi… Martin Thomson
- Re: [quicwg/base-drafts] Rewrite text about Versi… martinduke
- Re: [quicwg/base-drafts] Rewrite text about Versi… Marten Seemann
- Re: [quicwg/base-drafts] Rewrite text about Versi… Martin Thomson
- Re: [quicwg/base-drafts] Rewrite text about Versi… Mike Bishop
- Re: [quicwg/base-drafts] Rewrite text about Versi… Mike Bishop
- Re: [quicwg/base-drafts] Rewrite text about Versi… Mike Bishop
- Re: [quicwg/base-drafts] Rewrite text about Versi… Mike Bishop
- Re: [quicwg/base-drafts] Rewrite text about Versi… Kazuho Oku
- Re: [quicwg/base-drafts] Rewrite text about Versi… martinduke
- Re: [quicwg/base-drafts] Rewrite text about Versi… martinduke
- Re: [quicwg/base-drafts] Rewrite text about Versi… martinduke
- Re: [quicwg/base-drafts] Rewrite text about Versi… Martin Thomson
- Re: [quicwg/base-drafts] Rewrite text about Versi… Martin Thomson
- Re: [quicwg/base-drafts] Rewrite text about Versi… martinduke
- Re: [quicwg/base-drafts] Rewrite text about Versi… martinduke
- Re: [quicwg/base-drafts] Rewrite text about Versi… martinduke
- Re: [quicwg/base-drafts] Rewrite text about Versi… Martin Thomson
- Re: [quicwg/base-drafts] Rewrite text about Versi… Martin Thomson
- Re: [quicwg/base-drafts] Rewrite text about Versi… martinduke
- Re: [quicwg/base-drafts] Rewrite text about Versi… martinduke
- Re: [quicwg/base-drafts] Rewrite text about Versi… martinduke
- Re: [quicwg/base-drafts] Rewrite text about Versi… martinduke
- Re: [quicwg/base-drafts] Rewrite text about Versi… martinduke
- Re: [quicwg/base-drafts] Rewrite text about Versi… martinduke
- Re: [quicwg/base-drafts] Rewrite text about Versi… martinduke
- Re: [quicwg/base-drafts] Rewrite text about Versi… martinduke
- Re: [quicwg/base-drafts] Rewrite text about Versi… Martin Thomson
- Re: [quicwg/base-drafts] Rewrite text about Versi… Martin Thomson
- Re: [quicwg/base-drafts] Rewrite text about Versi… Martin Thomson