Re: [quicwg/base-drafts] Stronger migration handshake (#2370)

Kazuho Oku <notifications@github.com> Sun, 27 January 2019 22:29 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 62CD4130EE3 for <quic-issues@ietfa.amsl.com>; Sun, 27 Jan 2019 14:29:11 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -12.552
X-Spam-Level:
X-Spam-Status: No, score=-12.552 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bkM9u-67ngD4 for <quic-issues@ietfa.amsl.com>; Sun, 27 Jan 2019 14:29:09 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3B792130ECF for <quic-issues@ietf.org>; Sun, 27 Jan 2019 14:29:09 -0800 (PST)
Date: Sun, 27 Jan 2019 14:29:08 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1548628148; bh=j8MADUnNMf0AdcypKEimvH+Jah+yvpKE0D1xGp0aCdI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ftTn7BfBW0of8Af+ySk3CNIPM/MdAK+qcM01VeTzluC2UxzPmNbwnqXibsKsMoh2E dHHBpgz6WVJ5bVKDk6ByU4+9k4ygNV4qTYkLK5dN1DHCEvMxGfcUJpQBaXzmfl0xrX WZPGKyCmXpUFzlu7uhlEnPTQXnM3d6GIGPi4S3N8=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4aba2a810a04eb09c2e7dfc60e0fe56bdf7cae1e33a92cf000000011865f2b492a169ce180d1061@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2370/review/196848476@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2370@github.com>
References: <quicwg/base-drafts/pull/2370@github.com>
Subject: Re: [quicwg/base-drafts] Stronger migration handshake (#2370)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c4e30b42d161_70243fc476ed45c05176d4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/V5Kg_wR8mEf5c7q92G4zJ1ovRLs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 27 Jan 2019 22:29:11 -0000

kazuho commented on this pull request.



>  endpoints retaining a stable address for the duration of the handshake.
+An endpoint MUST NOT initiate connection migration before the handshake is
+finished for it and its peer and the endpoint has 1-RTT keys. This means
+that the server MUST NOT initiate connection migration before it has
+received at least one 1-RTT data from the client, and the client 
+MUST NOT initiate connection migration before receiving 
+acknowledgement by the server of at least one of its
+1-RTT messages.

How about reusing the event that triggers the 3 PTO timer to drop the handshake keys, instead of defining a different event?

Activation of the 3 PTO timer to drop the handshake key happens when an endpoint "has both received and acknowledged all CRYPTO frames for that encryption level and when all CRYPTO frames for that encryption level have been acknowledged by its peer." (https://quicwg.org/base-drafts/draft-ietf-quic-tls.html#rfc.section.4.9).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2370#pullrequestreview-196848476