IETF Logo Mail Archive

Re: [quicwg/base-drafts] Identify streams unidirectional vs bidirectional based on stream ID (#872)

MikkelFJ <notifications@github.com> Mon, 16 October 2017 00:47 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3B57B1332D4 for <quic-issues@ietfa.amsl.com>; Sun, 15 Oct 2017 17:47:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.018
X-Spam-Level:
X-Spam-Status: No, score=-2.018 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id J1KdosdtD_SX for <quic-issues@ietfa.amsl.com>; Sun, 15 Oct 2017 17:47:11 -0700 (PDT)
Received: from o10.sgmail.github.com (o10.sgmail.github.com [167.89.101.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AE55D1321A4 for <quic-issues@ietf.org>; Sun, 15 Oct 2017 17:47:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=QuTGjiH88Okc0TQGLpK6LsmJXUI=; b=esWDNSRuaxlq7+Ld 4XDrICHxNV46TOErakr2Ia04Iam+0rtsNvbwWvMvB8kdz04C/nm8LqQusl1UW5sV RoOvZpX4Moao1a6VxO1qP7MvEqNDtIKzwJOSJLx3J9Ff/bhE/pguTKjEUWgwMtTC Zzo69Z6uZwfmQW++E0EtFv24s/w=
Received: by filter1149p1mdw1.sendgrid.net with SMTP id filter1149p1mdw1-26262-59E4018E-1B 2017-10-16 00:47:10.882361902 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [192.30.253.16]) by ismtpd0010p1iad1.sendgrid.net (SG) with ESMTP id kCfLYzTaQlel5qiqELgxGg for <quic-issues@ietf.org>; Mon, 16 Oct 2017 00:47:10.799 +0000 (UTC)
Date: Mon, 16 Oct 2017 00:47:11 +0000
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab209c9fcce6bd3a9c2baa33b930fe7e3035e55b6092cf0000000115fbc38e92a169ce0fd14a5e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/872/c336754603@github.com>
In-Reply-To: <quicwg/base-drafts/pull/872@github.com>
References: <quicwg/base-drafts/pull/872@github.com>
Subject: Re: [quicwg/base-drafts] Identify streams unidirectional vs bidirectional based on stream ID (#872)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_59e4018eaf03d_41cf3fae14cc4f28463b1"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3YubO9wvtQmeeva2UgYawvxXWrr0tTtCjFhe fSPJNPaea+pWN86CU0rdjySFOSEHr/PTE7Op9qe7eQ4LVHwqaELpQQvMRCz1IB2eB/IUowYAVz22YD dTd7rM2dCEL/uw8Pl6Dccqj2a2z54p06pfRpZsQLU5AAbtTwEp+1qPCSk5dl/x0ADM2w44ekorD/Z7 8=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/V5Ohe_mXhQ3RWe0PWQidcfX0N4Q>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Oct 2017 00:47:13 -0000

While I am also concerned with the complexity of adding stream type into the ID (it adds a lot of special cases, but likely most alternatives would too), I don't think it is a good idea to have several ways of decoding varlen integers. It is best to have a single function to deal with endianness and unaligned read access and decoding, rather than several implementations.

If the bits are to be relocated, they could be placed in the frame type which can the be placed in the upper bits after decoding. But unfortunately that adds a lot of sub-frame types as Ian pointed out. Still, I think I prefer this. It makes it possible to immediately branch out on stream type.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/872#issuecomment-336754603

v2.46.0 | Report a Bug | By Email | System Status