Re: [quicwg/base-drafts] Clarify text around preferred address (#3589)

Mike Bishop <notifications@github.com> Mon, 20 April 2020 16:05 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7B9EA3A0A64 for <quic-issues@ietfa.amsl.com>; Mon, 20 Apr 2020 09:05:03 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.199
X-Spam-Level:
X-Spam-Status: No, score=-1.199 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9GKn66TUk_QG for <quic-issues@ietfa.amsl.com>; Mon, 20 Apr 2020 09:05:02 -0700 (PDT)
Received: from out-19.smtp.github.com (out-19.smtp.github.com [192.30.252.202]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D5AAF3A0A66 for <quic-issues@ietf.org>; Mon, 20 Apr 2020 09:05:01 -0700 (PDT)
Received: from github-lowworker-d31a065.va3-iad.github.net (github-lowworker-d31a065.va3-iad.github.net [10.48.17.70]) by smtp.github.com (Postfix) with ESMTP id C555E521F45 for <quic-issues@ietf.org>; Mon, 20 Apr 2020 09:05:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1587398700; bh=7DIKfRmRGhoOHAKFSuEU5mzW8/mvCQLDg3CxVELSFy8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=DVMyPqK8PtvO2KTs9tA2S9I+24aCR3oHbxHes3RSmXovTay7aUVxtnI8tMfKtsntW OoySsGoIr3QHy2dzYPXDPuzbQBEkjj7SrLCazAywAE5cpnC5DLIvCaxDDv8XUB2I1S GZvMxV/1KqL54IdvbUttgslUnIHiVjhPejc9NqZM=
Date: Mon, 20 Apr 2020 09:05:00 -0700
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3ZEBKHLQRO2EDF4BN4VGUSZEVBNHHCH4LVNY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3589/review/396590152@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3589@github.com>
References: <quicwg/base-drafts/pull/3589@github.com>
Subject: Re: [quicwg/base-drafts] Clarify text around preferred address (#3589)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e9dc82cb6cd8_58f83f8fdc2cd96c748952"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/V7sNx2XfIWBD3pDFP2tQXweN1Jw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Apr 2020 16:05:04 -0000

@MikeBishop approved this pull request.

For the semicolon ones which aren't in text you're actually changing, it might be better to leave them and do a separate editorial PR that cleans these up.  I'm sure the ones that hit the updated reference aren't the only ones.

> +Similarly, an endpoint MUST NOT reuse a connection ID when sending to more than
+one destination address, for example when responding to a change in the address
+of a peer if the packet with the new peer address uses an active connection ID
+that has not been previously used by the peer.

This is more precise, but still feels a little obtuse.  Would it be clearer to switch this into an exception?
```suggestion
Similarly, an endpoint MUST NOT reuse a connection ID when sending to more than
one destination address.  However, if an endpoint receives packets from a new
source address with the same destination connection ID, it MAY continue to use
the current connection ID with the new address.
```

> @@ -5654,7 +5663,7 @@ RETIRE_CONNECTION_ID frames contain the following fields:
 Sequence Number:
 
 : The sequence number of the connection ID being retired.  See

```suggestion
: The sequence number of the connection ID being retired; see
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3589#pullrequestreview-396590152