Re: [quicwg/base-drafts] Errors for bad stream-related frames (#1938)
Marten Seemann <notifications@github.com> Wed, 31 October 2018 04:38 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 752CF126DBF for <quic-issues@ietfa.amsl.com>; Tue, 30 Oct 2018 21:38:35 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Sl9rzDKoybjf for <quic-issues@ietfa.amsl.com>; Tue, 30 Oct 2018 21:38:33 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9C72B124D68 for <quic-issues@ietf.org>; Tue, 30 Oct 2018 21:38:33 -0700 (PDT)
Date: Tue, 30 Oct 2018 21:38:31 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1540960711; bh=HHFHMBlQImqSUo+XSrbJGrLuEh7IExF2bwkmA5s25A0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=xPMJkIrx9eAqwTF3+uPec7dznRQUN0T1yvHk3RWlTSnuxU6PJ21meCbQbEiaLsFn5 qJMS01lCRYKC75hbl25t6QOLjFBvNWAE5wZWgs1EDRrAnT0R8hsgV/O/exLi0llpnh hdZ23DeiWudJzZoveVtrfqOtRQOdnVjKTZhIBDmc=
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abc7faa6ca3b85a3084d77db46c471e152160740c792cf0000000117f0f3c792a169ce1665378d@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1938/review/170090147@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1938@github.com>
References: <quicwg/base-drafts/pull/1938@github.com>
Subject: Re: [quicwg/base-drafts] Errors for bad stream-related frames (#1938)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bd931c7afe3e_607e3f94d28d45b82922b"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/VOP9ChgRW0J5rjEJGy2uJWDRLww>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Oct 2018 04:38:36 -0000
marten-seemann commented on this pull request. There's also the case for unidirectional streams in the opposite direction, e.g. when a peer receives a MAX_DATA frame for a unidirectional stream that the other side initiated. > @@ -310,6 +306,13 @@ The two type bits from a Stream ID therefore identify streams as summarized in The first bidirectional stream opened by the client is stream 0. +If an endpoint receives a frame for a stream that it expects to initiate (i.e., +an even-numbered for the client or an odd-numbered for the server), but which it +has not yet opened, it MUST close the connection with error code +STREAM_STATE_ERROR. Similarly, receiving a STREAM or RST_STREAM frame for a This also applies to STREAM_DATA_BLOCKED. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1938#pullrequestreview-170090147
- [quicwg/base-drafts] Errors for bad stream-relate… Martin Thomson
- Re: [quicwg/base-drafts] Errors for bad stream-re… MikkelFJ
- Re: [quicwg/base-drafts] Errors for bad stream-re… janaiyengar
- Re: [quicwg/base-drafts] Errors for bad stream-re… Martin Thomson
- Re: [quicwg/base-drafts] Errors for bad stream-re… Martin Thomson
- Re: [quicwg/base-drafts] Errors for bad stream-re… Marten Seemann
- Re: [quicwg/base-drafts] Errors for bad stream-re… Martin Thomson
- Re: [quicwg/base-drafts] Errors for bad stream-re… MikkelFJ