Re: [quicwg/base-drafts] Grease HTTP error codes (#3360)

Mike Bishop <notifications@github.com> Tue, 21 January 2020 16:19 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 337B01208E8 for <quic-issues@ietfa.amsl.com>; Tue, 21 Jan 2020 08:19:52 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Szgpv6grBOn4 for <quic-issues@ietfa.amsl.com>; Tue, 21 Jan 2020 08:19:45 -0800 (PST)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 54E441201E5 for <quic-issues@ietf.org>; Tue, 21 Jan 2020 08:19:45 -0800 (PST)
Received: from github-lowworker-edec459.ac4-iad.github.net (github-lowworker-edec459.ac4-iad.github.net [10.52.18.32]) by smtp.github.com (Postfix) with ESMTP id AE0E76A0A71 for <quic-issues@ietf.org>; Tue, 21 Jan 2020 08:19:44 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1579623584; bh=wbNiSo65MAZ9FtWV7oROiCwT/iewblYgy2DI9tYrsYM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Fz1nWiTEH9quiRvf/nHp/9iN6UBoCJCQAA0L3h2+2388X1AAuyP+4iMwPQU5LMduX s/ugg6UCxHQxOnoo4LD2hzYLe9TPSlTdt1LerIkcQglz6FXgDqJHKRNjrp7Zzl+1nF q957TEnrY1O2BI4LPJ1i92aSAncsmMaKkazwirOc=
Date: Tue, 21 Jan 2020 08:19:44 -0800
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK372CHVZA46PYYXR7V4GRLSBEVBNHHCBYJK2Q@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3360/review/346007549@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3360@github.com>
References: <quicwg/base-drafts/pull/3360@github.com>
Subject: Re: [quicwg/base-drafts] Grease HTTP error codes (#3360)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e2724a07e045_10823fcb6f2cd95c132448"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/VQ8BrGXv1QjvLwkiy5R0xaf60ak>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Jan 2020 16:19:52 -0000

MikeBishop commented on this pull request.



> @@ -925,7 +925,9 @@ transferred. Endpoints MUST NOT consider these streams to have any meaning upon
 receipt.
 
 The payload and length of the stream are selected in any manner the
-implementation chooses.
+implementation chooses.  Implementations MAY terminate these streams cleanly,
+or MAY abruptly terminate them with an error code of the implementation's
+choice, including reserved error codes ({{http-error-codes}}).

As @LPardue says, we only have defined semantics for CLOSED_CRITICAL_STREAM as a connection error.  (And, for that matter, those semantics don't include any action on the receiver's part.)  Receiving it on a stream -- especially a grease stream -- is supposed to have no effect.  If it does, greasing is working.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3360#discussion_r369100624