Re: [quicwg/base-drafts] Rework idle timeout definition (#2346)

[Dmitri Tikhonov <[e-mail]>]

dtikhonov commented on this pull request.



> @@ -2242,14 +2242,13 @@ If the idle timeout is enabled, a connection that remains idle for longer than
 the advertised idle timeout (see {{transport-parameter-definitions}}) is closed.
 A connection enters the draining state when the idle timeout expires.
 
-Each endpoint advertises its own idle timeout to its peer. The idle timeout
-starts from the last packet received.  In order to ensure that initiating new
-activity postpones an idle timeout, an endpoint restarts this timer when sending
-a packet.  An endpoint does not postpone the idle timeout if another packet has
-been sent containing frames other than ACK or PADDING, and that other packet has
-not been acknowledged or declared lost.  Packets that contain only ACK or
-PADDING frames are not acknowledged until an endpoint has other frames to send,
-so they could prevent the timeout from being refreshed.
+Each endpoint advertises its own idle timeout to its peer.  Endpoints restart

I'd switch to the singular number:

> _An enpdpoint restarts any timer it maintains when a packet from its peer_....

As it stands, it sounds as if several endpoints had a single peer.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2346#pullrequestreview-194104002