Re: [quicwg/base-drafts] Forbid duplicate setting identifiers. (#2979)

Martin Thomson <notifications@github.com> Wed, 21 August 2019 02:25 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6EFF512021C for <quic-issues@ietfa.amsl.com>; Tue, 20 Aug 2019 19:25:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iwpxtTWmyewO for <quic-issues@ietfa.amsl.com>; Tue, 20 Aug 2019 19:25:15 -0700 (PDT)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E69BD120144 for <quic-issues@ietf.org>; Tue, 20 Aug 2019 19:25:14 -0700 (PDT)
Date: Tue, 20 Aug 2019 19:25:13 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1566354313; bh=WlTBO8qetrchNflg9H9+3CTzdR149dFb2JOJdoRKuv4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=dmEj6MhB0GGIinRsAvFxCzp9W/THlPdiWVeJWZoRFhPW9HHToz4UrpfO6MzYP+aj1 /9GCHCQonbxktHxTFRQexAclzDlHZkCHR7N6nmRwGyfJgQTr4d5tQcoc3d3h3OWz8E FM6tuI9TdZ267aKCHV7mdK8kYtGkuFwqV9lXBIrw=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYHWKCXGDWA5VAQZW53NHPATEVBNHHBZSDTTE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2979/review/277529258@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2979@github.com>
References: <quicwg/base-drafts/pull/2979@github.com>
Subject: Re: [quicwg/base-drafts] Forbid duplicate setting identifiers. (#2979)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d5cab89dc203_76573fec7accd96c14915a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/V_xUPG_Ps2yKUX5Yjv5Yz9s_Zk0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Aug 2019 02:25:16 -0000

martinthomson approved this pull request.

An alternative below.  But this is good either way.

> @@ -1340,9 +1340,9 @@ Different values for the same parameter can be advertised by each peer. For
 example, a client might be willing to consume a very large response header,
 while servers are more cautious about request size.
 
-Parameters MUST NOT occur more than once in the SETTINGS frame.  A receiver MAY
-treat the presence of the same parameter more than once as a connection error of
-type HTTP_SETTINGS_ERROR.
+Setting identifiers MUST NOT occur more than once in the SETTINGS frame.  A

```suggestion
The same setting identifier MUST NOT occur more than once in the SETTINGS frame.  A
```

> @@ -1340,9 +1340,9 @@ Different values for the same parameter can be advertised by each peer. For
 example, a client might be willing to consume a very large response header,
 while servers are more cautious about request size.
 
-Parameters MUST NOT occur more than once in the SETTINGS frame.  A receiver MAY
-treat the presence of the same parameter more than once as a connection error of
-type HTTP_SETTINGS_ERROR.
+Setting identifiers MUST NOT occur more than once in the SETTINGS frame.  A
+receiver MAY treat the presence of the same setting identifier more than once as

```suggestion
receiver MAY treat the presence of duplicate setting identifiers as
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2979#pullrequestreview-277529258