Re: [quicwg/base-drafts] Servers have to change connection IDs in Retry (#3147)

MikkelFJ <notifications@github.com> Fri, 25 October 2019 06:37 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A615F1200F9 for <quic-issues@ietfa.amsl.com>; Thu, 24 Oct 2019 23:37:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h4Iwp1NiLadR for <quic-issues@ietfa.amsl.com>; Thu, 24 Oct 2019 23:37:52 -0700 (PDT)
Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5584F1200F7 for <quic-issues@ietf.org>; Thu, 24 Oct 2019 23:37:52 -0700 (PDT)
Date: Thu, 24 Oct 2019 23:37:51 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1571985471; bh=LHKSo2NboBBV6o5aNCcndS8bFR+OG1SeXrUgborijc0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=gD4HRVchOGBZfWH24gjxdUK8dtn85QxbGPZ1uEFP0N3+LmmKvVc+maudc1LNJm3As w+33JyqhU+g4kjFgrIXxVC5QRreUu8bF4Fx0zB6HZ0ppAWYztuIntdQwQan2s2eBhP 65GpYZznYBOPLLLF7HqXE7lAN/JtPkaDb/z2jumk=
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4HQ7H2BSFGEO3VNUF3X7MM7EVBNHHB476GMM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3147/review/307006058@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3147@github.com>
References: <quicwg/base-drafts/pull/3147@github.com>
Subject: Re: [quicwg/base-drafts] Servers have to change connection IDs in Retry (#3147)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5db2983f4ed14_3ffd3f9d272cd964215010"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Vj12_38vSYj9UikAWV76YNvWGrQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Oct 2019 06:37:53 -0000

mikkelfj commented on this pull request.



> @@ -4150,8 +4154,10 @@ the client included in the Source Connection ID of the Initial packet.
 
 The server includes a connection ID of its choice in the Source Connection ID
 field.  This value MUST not be equal to the Destination Connection ID field of
-the packet sent by the client.  The client MUST use this connection ID in the
-Destination Connection ID of subsequent packets that it sends.
+the packet sent by the client.  A client MUST discard a Retry packet that
+contains a Source Connection ID field that is identical to the Destination
+Connection ID field of its Initial packet.  The client MUST use this connection
+ID in the Destination Connection ID field of subsequent packets that it sends.
 

Post merge, but "The client MIST use this connection ID" reads as if it refers to the invalid duplicate ID.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3147#pullrequestreview-307006058