Re: [quicwg/base-drafts] allow PRIORITY frames referring to placeholders exceeding `SETTING_NUM_PLACEHOLDERS` (#2761)
Lucas Pardue <notifications@github.com> Fri, 31 May 2019 10:17 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 927B5120025 for <quic-issues@ietfa.amsl.com>; Fri, 31 May 2019 03:17:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.008
X-Spam-Level:
X-Spam-Status: No, score=-8.008 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j7Zik4eK24Ev for <quic-issues@ietfa.amsl.com>; Fri, 31 May 2019 03:17:19 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 78D9512001B for <quic-issues@ietf.org>; Fri, 31 May 2019 03:17:19 -0700 (PDT)
Date: Fri, 31 May 2019 03:17:18 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1559297838; bh=KJRHHQ//x6dDoDlV5z/u5dQdHmvvA4gvSCHMJIbKP9k=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=cX4VcczJihMM1bpOoGg/TdENVVlH/TmkaRT5JqsrVorRMTbRmXa+egglzjjcdD58F 6WfSEqOvwoxxqISMQbNZDVn6nGk6u6KDnu006b+I1NqSljO/YDp0qKX9nURZjuvcbt YSudP76mL7sV56zcXjs2kI5Gz3z7dxa6VWojaJso=
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYRVMRAPXHV7GVQXN527YY25EVBNHHBVW7INY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2761/review/244235054@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2761@github.com>
References: <quicwg/base-drafts/pull/2761@github.com>
Subject: Re: [quicwg/base-drafts] allow PRIORITY frames referring to placeholders exceeding `SETTING_NUM_PLACEHOLDERS` (#2761)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cf0ff2e4f6ae_4b423f8bcaccd96422685e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/VjtxfK_s_Bs5nwiVje9SmI2OTb0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 31 May 2019 10:17:22 -0000
LPardue commented on this pull request. > @@ -1202,9 +1202,15 @@ The following situations are examples of invalid PRIORITY frames: A PRIORITY frame with Empty bits not set to zero MAY be treated as a connection error of type HTTP_MALFORMED_FRAME. -A PRIORITY frame that references a non-existent Push ID, a Placeholder ID -greater than the server's limit, or a Stream ID the client is not yet permitted -to open MUST be treated as a connection error of type HTTP_LIMIT_EXCEEDED. +A PRIORITY frame that references a non-existent Push ID, or a Stream ID the +client is not yet permitted to open MUST be treated as a connection error of +type HTTP_LIMIT_EXCEEDED. + +A PRIORITY frame MAY reference a Placeholder ID that is equal to or greater than +the server's advertised value of the `SETTINGS_NUM_PLACEHOLDERS` settings. The +server SHOULD ignore PRIORITY frames that specify such placeholders as the +prioritized element. The server SHOULD use the root of the tree as the I think you want s/prioritized element/element dependency. Such that if a stream is assigned as dependent on a placeholder ID greater than SETTINGS_NUM_PLACEHOLDERS, then it becomes dependent on root. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2761#pullrequestreview-244235054
- [quicwg/base-drafts] allow PRIORITY frames referr… Kazuho Oku
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Kazuho Oku
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Lucas Pardue
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Lucas Pardue
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Kazuho Oku
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Kazuho Oku
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Lucas Pardue
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Lucas Pardue
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Alessandro Ghedini
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Lucas Pardue
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Alessandro Ghedini
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Lucas Pardue
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Kazuho Oku
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Kazuho Oku
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Robin Marx
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Robin Marx
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Kazuho Oku
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Kazuho Oku
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Kazuho Oku
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Mike Bishop
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Kazuho Oku
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Kazuho Oku
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Kazuho Oku
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Kazuho Oku
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Mike Bishop
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Kazuho Oku
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Kazuho Oku
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Kazuho Oku
- Re: [quicwg/base-drafts] allow PRIORITY frames re… ianswett
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Martin Thomson
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Kazuho Oku
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Mike Bishop
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Mike Bishop
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Kazuho Oku
- Re: [quicwg/base-drafts] allow PRIORITY frames re… ianswett
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Kazuho Oku
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Kazuho Oku
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Robin Marx
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Kazuho Oku
- Re: [quicwg/base-drafts] allow PRIORITY frames re… ianswett
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Kazuho Oku
- Re: [quicwg/base-drafts] allow PRIORITY frames re… ianswett
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Mike Bishop
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Kazuho Oku
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Kazuho Oku
- Re: [quicwg/base-drafts] allow PRIORITY frames re… ianswett
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Kazuho Oku
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Mike Bishop
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Mike Bishop
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Martin Thomson
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Kazuho Oku
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Kazuho Oku
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Kazuho Oku
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Kazuho Oku
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Kazuho Oku
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Martin Thomson
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Mike Bishop
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Kazuho Oku
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Kazuho Oku
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Kazuho Oku
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Mike Bishop
- Re: [quicwg/base-drafts] allow PRIORITY frames re… Mike Bishop