Date: Wed, 30 Oct 2019 10:00:51 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK2ZJZB6JVHPSF3L4G53Y4BFHEVBNHHB5HMNYI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3164/review/309368549@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3164@github.com>
References: <quicwg/base-drafts/pull/3164@github.com>
Subject: Re: [quicwg/base-drafts] Forbid use of application-level close in
 Initial, Handshake packets (#3164)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5db9c1c3d9437_5a643fd264ccd960188970";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Vtzq5xb-9jsGNWVTo4fOaD64TnA>


----==_mimepart_5db9c1c3d9437_5a643fd264ccd960188970
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

ianswett approved this pull request.



> @@ -328,8 +328,11 @@ encryption levels:
 
 - PADDING and PING frames MAY appear in packets of any encryption level.
 
-- CRYPTO and CONNECTION_CLOSE frames MAY appear in packets of any encryption
-  level except 0-RTT.
+- CRYPTO frames and CONNECTION_CLOSE frames signaling errors at QUIC layer (type
+  0x1c) MAY appear in packets of any encryption level except 0-RTT.
+
+- CONNECTION_CLOSE frames signaling application errors (type 0x1d) MUST only be
+  sent in 1-RTT level.

```suggestion
  sent in the 1-RTT encryption level.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3164#pullrequestreview-309368549
----==_mimepart_5db9c1c3d9437_5a643fd264ccd960188970
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<p><b>@ianswett</b> approved this pull request.</p>=0D
=0D
<hr>=0D
=0D
<p>In <a href=3D"https://github.com/quicwg/base-drafts/pull/3164#discussi=
on_r340741992">draft-ietf-quic-tls.md</a>:</p>=0D
<pre style=3D'color:#555'>&gt; @@ -328,8 +328,11 @@ encryption levels:=0D=

 =0D
 - PADDING and PING frames MAY appear in packets of any encryption level.=
=0D
 =0D
-- CRYPTO and CONNECTION_CLOSE frames MAY appear in packets of any encryp=
tion=0D
-  level except 0-RTT.=0D
+- CRYPTO frames and CONNECTION_CLOSE frames signaling errors at QUIC lay=
er (type=0D
+  0x1c) MAY appear in packets of any encryption level except 0-RTT.=0D
+=0D
+- CONNECTION_CLOSE frames signaling application errors (type 0x1d) MUST =
only be=0D
+  sent in 1-RTT level.=0D
</pre>=0D
=E2=AC=87=EF=B8=8F Suggested change=0D
<pre style=3D"color: #555">-  sent in 1-RTT level.=0D
+  sent in the 1-RTT encryption level.=0D
</pre>=0D
=0D
=0D
<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />You are receiving this because you are subscribed to this thre=
ad.<br />Reply to this email directly, <a href=3D"https://github.com/quic=
wg/base-drafts/pull/3164?email_source=3Dnotifications&amp;email_token=3DA=
FTOJK3SWWJZH4X6JRT3IMTQRG4UHA5CNFSM4JGCFZ6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJ=
SXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJYJNZI#pullrequestreview-309368549=
">view it on GitHub</a>, or <a href=3D"https://github.com/notifications/u=
nsubscribe-auth/AFTOJK4QG4QC5RWA5S2LMNLQRG4UHANCNFSM4JGCFZ6A">unsubscribe=
</a>.<img src=3D"https://github.com/notifications/beacon/AFTOJK6TP34MBFPU=
SMAWAIDQRG4UHA5CNFSM4JGCFZ6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWN=
FSXPKTDN5WW2ZLOORPWSZGOCJYJNZI.gif" height=3D"1" width=3D"1" alt=3D"" /><=
/p>=0D
<script type=3D"application/ld+json">[=0D
{=0D
"@context": "http://schema.org",=0D
"@type": "EmailMessage",=0D
"potentialAction": {=0D
"@type": "ViewAction",=0D
"target": "https://github.com/quicwg/base-drafts/pull/3164?email_source=3D=
notifications\u0026email_token=3DAFTOJK3SWWJZH4X6JRT3IMTQRG4UHA5CNFSM4JGC=
FZ6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOC=
JYJNZI#pullrequestreview-309368549",=0D
"url": "https://github.com/quicwg/base-drafts/pull/3164?email_source=3Dno=
tifications\u0026email_token=3DAFTOJK3SWWJZH4X6JRT3IMTQRG4UHA5CNFSM4JGCFZ=
6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJY=
JNZI#pullrequestreview-309368549",=0D
"name": "View Pull Request"=0D
},=0D
"description": "View this Pull Request on GitHub",=0D
"publisher": {=0D
"@type": "Organization",=0D
"name": "GitHub",=0D
"url": "https://github.com"=0D
}=0D
}=0D
]</script>=

----==_mimepart_5db9c1c3d9437_5a643fd264ccd960188970--