IETF Logo Mail Archive

Re: [quicwg/base-drafts] Proposal for adding ECN support to QUIC. (#1372)

ianswett <notifications@github.com> Fri, 22 June 2018 19:10 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 68EAE130EC6 for <quic-issues@ietfa.amsl.com>; Fri, 22 Jun 2018 12:10:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.01
X-Spam-Level:
X-Spam-Status: No, score=-3.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mVUTrUshSabW for <quic-issues@ietfa.amsl.com>; Fri, 22 Jun 2018 12:10:00 -0700 (PDT)
Received: from o11.sgmail.github.com (o11.sgmail.github.com [167.89.101.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 68514130EC0 for <quic-issues@ietf.org>; Fri, 22 Jun 2018 12:09:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=t9Qz1i8/lZMwGX2YUXY2A/g8X8k=; b=B1NR/IuYirwcCMg7 q/Ie6AFtKxgY7RSg2KlUxPrpp6IK2Vy2T0n6fpx9D43kGyIpNyO+Q4VFSWw97drq amW4S16uWMGquNOzImT8EM4lY1EMYYlWbqzCvVHKUXOtiPKzEch7Tdn7JfIixdIU X23oA/Ew+Eih8ap5D61STPcVlX8=
Received: by filter0271p1iad2.sendgrid.net with SMTP id filter0271p1iad2-17875-5B2D4980-48 2018-06-22 19:09:52.655416349 +0000 UTC
Received: from github-lowworker-b40b5a4.cp1-iad.github.net (unknown [192.30.252.36]) by ismtpd0002p1iad1.sendgrid.net (SG) with ESMTP id NHZeDSjqRh23u_2QKpqpZA for <quic-issues@ietf.org>; Fri, 22 Jun 2018 19:09:52.674 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-b40b5a4.cp1-iad.github.net (Postfix) with ESMTP id A2B503E1973 for <quic-issues@ietf.org>; Fri, 22 Jun 2018 12:09:52 -0700 (PDT)
Date: Fri, 22 Jun 2018 19:09:52 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab9a3a35dc9950b9300b96c3c6788e0f1402ebdeea92cf0000000117450b8092a169ce13656182@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1372/review/131313634@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1372@github.com>
References: <quicwg/base-drafts/pull/1372@github.com>
Subject: Re: [quicwg/base-drafts] Proposal for adding ECN support to QUIC. (#1372)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b2d4980a0c22_3b842b119c6c4f5c784b0"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0obxHix9I6MADgCZlT1d4ZPmVkV2/WtUqS+W oD12HZPuuP/OldmhvGpm0d2DSgzExUMQ/uxsUClbETfgLYjuchOGAtvulRZ9N/mJ4LtJoZ13Uh7fk7 4r8GYkQ1cWdzmaZHRC+J729IA7biQTfzvP0Y3ZdjvGl4KQCOE4XS057P3JziRQvgwx3QqmYj7FHumW E=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/VyXXT48vgoaVcubuh-_i_IMUKyU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Jun 2018 19:10:03 -0000

ianswett commented on this pull request.

Two comments on the frame diagram.

> @@ -2999,10 +2999,10 @@ appended at the end.
 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
 |                       ACK Block Count (i)                   ...
 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+

Can you move the ACK Block Count down as well.  It's odd to have that up here.

> @@ -2999,10 +2999,10 @@ appended at the end.
 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
 |                       ACK Block Count (i)                   ...
 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+

Also, how about putting the ECN info in this diagram, rather than having it in a separate diagram?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1372#pullrequestreview-131313634

v2.46.0 | Report a Bug | By Email | System Status