Date: Tue, 25 Sep 2018 00:37:11 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4ab780aa7a211af60361d0b7c8a3e5b2fcec602b59192cf0000000117c1a7a792a169ce15a864f1@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1792/review/158410043@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1792@github.com>
References: <quicwg/base-drafts/pull/1792@github.com>
Subject: Re: [quicwg/base-drafts] Remove EndOfEarlyData from TLS (#1792)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5ba9e5a768cf4_61a23ff69dcd45b41609a8";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/W8ReR8ajZiN7cbcKqnBfRmboH3Q>


----==_mimepart_5ba9e5a768cf4_61a23ff69dcd45b41609a8
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

ianswett commented on this pull request.



> @@ -465,10 +465,9 @@ and lower encryption levels than the current encryption level used by TLS.
 
 In particular, server implementations need to be able to read packets at the
 Handshake encryption level before the final TLS handshake message at the 0-RTT

What's the final TLS handshake message at the 0-RTT encryption level?  Overall, I'm not sure what this paragraph is trying to add to the previous one.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1792#pullrequestreview-158410043
----==_mimepart_5ba9e5a768cf4_61a23ff69dcd45b41609a8
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@ianswett</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/1792#discussion_r220085836">draft-ietf-quic-tls.md</a>:</p>
<pre style='color:#555'>&gt; @@ -465,10 +465,9 @@ and lower encryption levels than the current encryption level used by TLS.
 
 In particular, server implementations need to be able to read packets at the
 Handshake encryption level before the final TLS handshake message at the 0-RTT
</pre>
<p>What's the final TLS handshake message at the 0-RTT encryption level?  Overall, I'm not sure what this paragraph is trying to add to the previous one.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/1792#pullrequestreview-158410043">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkq5W5yQuJlDgUuo-4PH0YhbMtzzTDks5ued0ngaJpZM4W3n8I">mute the thread</a>.<img src="https://github.com/notifications/beacon/AWbkq-g7WsGoa4RnvEanJjq7Ya4gP2c0ks5ued0ngaJpZM4W3n8I.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ianswett commented on #1792"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/1792#pullrequestreview-158410043"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/1792#pullrequestreview-158410043",
"url": "https://github.com/quicwg/base-drafts/pull/1792#pullrequestreview-158410043",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@ianswett commented on 1792",
"sections": [
{
"text": "",
"activityTitle": "**ianswett**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ianswett",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/quicwg/base-drafts/pull/1792#pullrequestreview-158410043"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 383680264\n}"
}
],
"themeColor": "26292E"
}
]</script>
----==_mimepart_5ba9e5a768cf4_61a23ff69dcd45b41609a8--