Re: [quicwg/base-drafts] Mandatory distinction between token types (#3128)

Martin Thomson <notifications@github.com> Tue, 22 October 2019 04:29 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3379512004F for <quic-issues@ietfa.amsl.com>; Mon, 21 Oct 2019 21:29:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.382
X-Spam-Level:
X-Spam-Status: No, score=-1.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XVjjl2QQCb8s for <quic-issues@ietfa.amsl.com>; Mon, 21 Oct 2019 21:29:08 -0700 (PDT)
Received: from o5.sgmail.github.com (o5.sgmail.github.com [192.254.113.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F0148120058 for <quic-issues@ietf.org>; Mon, 21 Oct 2019 21:29:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=zUmIB1awYlsI5V/NY4aiwI45fZo=; b=voOiniERi8Qu+DKU ObM1E3mtLSFtovtp3nPV8A9UY5Oc8I+zM5YGICIzkQgERdzdZEW+HSLL9fgrelKa jP0bXc+tx7u/r6IHolEjwPsR2AP2e6yRrUkZsf93TNR7F1XX/pNDNH9gjC7Vi/W1 7VRxfFm2yiodNL8hZieBy+rTZAM=
Received: by filter0934p1las1.sendgrid.net with SMTP id filter0934p1las1-8495-5DAE7D25-8 2019-10-22 03:53:09.283714661 +0000 UTC m=+363686.037931484
Received: from out-17.smtp.github.com (out-17.smtp.github.com [192.30.252.200]) by ismtpd0092p1iad2.sendgrid.net (SG) with ESMTP id r5ADv6ulSbuzRVnrJkoK9Q for <quic-issues@ietf.org>; Tue, 22 Oct 2019 03:53:09.178 +0000 (UTC)
Received: from github-lowworker-19d82f6.ac4-iad.github.net (github-lowworker-19d82f6.ac4-iad.github.net [10.52.16.75]) by smtp.github.com (Postfix) with ESMTP id E84E86E0023 for <quic-issues@ietf.org>; Mon, 21 Oct 2019 20:53:03 -0700 (PDT)
Date: Tue, 22 Oct 2019 03:53:09 +0000 (UTC)
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYLK4JSNZAF5DHMESF3XO627EVBNHHB43A2P4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3128/review/304953757@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3128@github.com>
References: <quicwg/base-drafts/pull/3128@github.com>
Subject: Re: [quicwg/base-drafts] Mandatory distinction between token types (#3128)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dae7d1fd89cf_355c3fc9210cd96811846e"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2wIBy+1n8bOs28jXVEhE5YquVNR7zlSuTouu ZZr0eMQbeVDV+JQViOoxQ/POrCB17cwRwvQ1RLqstsBvlZR5WZ98Itk19dMXSttPx/RCf6qfzGw+pF u/Ia4R/dRmAfkBRxkbT8ZYWw19OMsf519GJNOpzdROpoQOvUw/pSYa/igkYQtxRDJ1Qjx/pdJad8fT g=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/WCrmt-kZPr_A8cqMToJ6L7QCkpY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Oct 2019 04:29:09 -0000

martinthomson commented on this pull request.



> @@ -1623,6 +1623,20 @@ also constrained in what they can send by the limits set by the congestion
 controller.  Clients are only constrained by the congestion controller.
 
 
+### Token Construction
+
+Tokens sent in NEW_TOKEN frames or Retry packets MUST be constructed in a way
+that allows the server to identity how it was provided to a client.  These
+tokens are carried in the same field, but require different handling from
+servers.
+
+A token MUST NOT include information that would allow values to be linked by an

Yeah, I moved too much up.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3128#discussion_r337322707