Re: [quicwg/base-drafts] http: Allow unquoted tokens in Alt-Svc quic parameter (#3063)

Tatsuhiro Tsujikawa <notifications@github.com> Tue, 24 September 2019 14:30 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 30ED0120072 for <quic-issues@ietfa.amsl.com>; Tue, 24 Sep 2019 07:30:26 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.281
X-Spam-Level:
X-Spam-Status: No, score=-6.281 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id p1sopb_037Xi for <quic-issues@ietfa.amsl.com>; Tue, 24 Sep 2019 07:30:25 -0700 (PDT)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C2DF012001A for <quic-issues@ietf.org>; Tue, 24 Sep 2019 07:30:24 -0700 (PDT)
Received: from github-lowworker-25680bd.va3-iad.github.net (github-lowworker-25680bd.va3-iad.github.net [10.48.17.61]) by smtp.github.com (Postfix) with ESMTP id EADCB6A03AF for <quic-issues@ietf.org>; Tue, 24 Sep 2019 07:30:23 -0700 (PDT)
Date: Tue, 24 Sep 2019 07:30:23 -0700
From: Tatsuhiro Tsujikawa <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK57YS53TTLOGFYTSVF3S5NP7EVBNHHB3JNFTE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3063/534585821@github.com>
In-Reply-To: <quicwg/base-drafts/issues/3063@github.com>
References: <quicwg/base-drafts/issues/3063@github.com>
Subject: Re: [quicwg/base-drafts] http: Allow unquoted tokens in Alt-Svc quic parameter (#3063)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d8a287fdb5ad_67763fa8864cd95c1727d0"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: tatsuhiro-t
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/WIV4nksr8Hl7ZzYnMjvux88TnUg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Sep 2019 14:30:26 -0000

I support allowing unquoted token for alt-svc quic parameter.
quic=1 and quic="1" are semantically the same, and there is no reason to disallow unquoted token.
Moreover, requiring quoted-string means that we cannot use generic alt-svc parser because such parser can parse quic=1 without an error.  You need to write your own parser to detect that the DQUOTE is really there.  If you think that detecting it is not necessary, then requiring quoted-string is not necessary in the first place.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3063#issuecomment-534585821