Re: [quicwg/base-drafts] Add an appendix containing test vectors for "Initial". (#1573)

Martin Thomson <notifications@github.com> Wed, 15 August 2018 00:59 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6A683130E3E for <quic-issues@ietfa.amsl.com>; Tue, 14 Aug 2018 17:59:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rPjGL1ZV5lu5 for <quic-issues@ietfa.amsl.com>; Tue, 14 Aug 2018 17:59:51 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 19B92130E2F for <quic-issues@ietf.org>; Tue, 14 Aug 2018 17:59:51 -0700 (PDT)
Date: Tue, 14 Aug 2018 17:59:50 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1534294790; bh=3TBu8tIDir7IhvOTmpH9JaLc9SgXtw6hP5zcZK4awrY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=JdavFQxKVzjz9eRG6roVRZo/lKlLrK4nW5+JILh6+BV5OniCefKJkcgK6CYz79ydC WgsDAy3KEN2XQS/a7aE2gkqTpdd87RJCY0+mQ2LO197u7O6obGTUllqNnqmj3Bifip dx0nbqDx0Mzy+NJjLmyJM1Im6pZbPKFqFhflObm0=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4aba5aeef2357c352819bf7c1da66944097cea48e9992cf00000001178b3d0692a169ce145eeded@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1573/review/141400767@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1573@github.com>
References: <quicwg/base-drafts/pull/1573@github.com>
Subject: Re: [quicwg/base-drafts] Add an appendix containing test vectors for "Initial". (#1573)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b737b064d4bf_632b3f85be4be6182569ef"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/WNCgRJCg1Ad28PRjWCrbfTX6T6Q>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Aug 2018 00:59:53 -0000

martinthomson requested changes on this pull request.

I think that these are incorrect.

> +
+{{initial-secrets}} contains the salt used for Initial Packet
+Encryption.
+Using the Initial Destination Connection ID 0x8394c8f03e515708, the
+derived 32 byte initial secret is:
+
+~~~
+  a5 72 b0 24 5a f1 ed df 5c 61 c6 e3 f7 f9 30 4c
+  a6 6b fb 4c aa f7 65 67 d5 cb 8d d1 dc 4e 82 0b
+~~~
+
+The labels generated by the HKDF-Expand-Label function are:
+
+~~~
+  quic client in: 00 20 0e 71 75 69 63 20 63 6c 69 65 6e 74 20
+                  69 6e

These labels all omit the trailing zero octet for the context.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1573#pullrequestreview-141400767