Re: [quicwg/base-drafts] Clarify when a dynamic table entry can be evicted. (#2261)

Bence Béky <notifications@github.com> Fri, 25 January 2019 01:00 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4EA1312D4E9 for <quic-issues@ietfa.amsl.com>; Thu, 24 Jan 2019 17:00:17 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -10.17
X-Spam-Level:
X-Spam-Status: No, score=-10.17 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FROM_EXCESS_BASE64=0.979, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1Kz7NW0kZYjU for <quic-issues@ietfa.amsl.com>; Thu, 24 Jan 2019 17:00:15 -0800 (PST)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8AA3D128D09 for <quic-issues@ietf.org>; Thu, 24 Jan 2019 17:00:15 -0800 (PST)
Date: Thu, 24 Jan 2019 17:00:13 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1548378013; bh=TnbL6xCPDataUXdjMyqqOJGQ8gDQrJWm6+2XV2rwIik=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Pn3q0+lKwAo3A/xIiYzyHs0MALWZZys9MRC/dDDUq6Yh21nMO0bOQ168Bkj+e3zMc 1YhjzxVyke+tByzryUHskVXsQv52XTra00u+b6uLCylKyxN2AIoln7oymHM2q5djU/ Sz4S/nq9cFL4U/bqS+VnuMcK6d7LkmjsxfNc3EPA=
From: Bence Béky <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab7079aa88407892726f33adc943f4abad1146f99a92cf000000011862219d92a169ce177f2f28@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2261/review/196320996@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2261@github.com>
References: <quicwg/base-drafts/pull/2261@github.com>
Subject: Re: [quicwg/base-drafts] Clarify when a dynamic table entry can be evicted. (#2261)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c4a5f9d79f16_4ea83f7ecdcd45c088107b"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: bencebeky
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/WTsNiMOWrzkQhM2tXAXxB9riixE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Jan 2019 01:00:17 -0000

bencebeky commented on this pull request.



> @@ -210,10 +210,18 @@ acknowledged by the decoder.
 
 ### Blocked Dynamic Table Insertions {#blocked-insertion}
 
+The encoder considers a dynamic table entry to be blocking if it has not yet
+received acknowledgement of insertion of the entry, or if it has not yet
+received acknowledgement of all references to the entry.  Note that a dynamic
+table entry that has never been referenced can still be blocking.  Also note

Indeed it is.  However, I think it is worth keeping, especially because at two places in the spec this aspect of blocking has been overlooked.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2261#discussion_r250834601