IETF Logo Mail Archive

Re: [quicwg/base-drafts] Rework Key Update (#2237)

Nick Banks <notifications@github.com> Wed, 13 February 2019 15:18 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6476412867A for <quic-issues@ietfa.amsl.com>; Wed, 13 Feb 2019 07:18:32 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.597
X-Spam-Level:
X-Spam-Status: No, score=-1.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dOCr5zDGokqO for <quic-issues@ietfa.amsl.com>; Wed, 13 Feb 2019 07:18:31 -0800 (PST)
Received: from o1.sgmail.github.com (o1.sgmail.github.com [192.254.114.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8E79C126C7E for <quic-issues@ietf.org>; Wed, 13 Feb 2019 07:18:30 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=KrozEHMA2Lj50qE88MkDiujrs+g=; b=h2uXAK7rHdTGYVrR kTc2cTZB+mVnZYdswaSfj1rANDJukQTG59zTHTi9N+uCEhvRS+FnHEP8CqpbHVBs TlX6ZyjZDYPr4GlWo3KotwfGzTEmRjoijZzb+NKyWSMBr3ASf/XAmiLtpz9bFHD7 W93Risiwty8JFrHJaEAoXdKH7lE=
Received: by filter1795p1mdw1.sendgrid.net with SMTP id filter1795p1mdw1-4970-5C643531-21 2019-02-13 15:18:09.295624567 +0000 UTC m=+418912.058579419
Received: from github-lowworker-e711880.cp1-iad.github.net (unknown [192.30.252.45]) by ismtpd0005p1iad2.sendgrid.net (SG) with ESMTP id 81Y4SqdPRpqIDws609P8jw for <quic-issues@ietf.org>; Wed, 13 Feb 2019 15:18:09.309 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-e711880.cp1-iad.github.net (Postfix) with ESMTP id 3C62B44078B for <quic-issues@ietf.org>; Wed, 13 Feb 2019 07:18:09 -0800 (PST)
Date: Wed, 13 Feb 2019 15:18:09 +0000
From: Nick Banks <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab6b647d9ee8e324f9d978e9d770036d3b6f778f4992cf00000001187bf73192a169ce1770e975@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2237/review/203267366@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2237@github.com>
References: <quicwg/base-drafts/pull/2237@github.com>
Subject: Re: [quicwg/base-drafts] Rework Key Update (#2237)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c6435313a612_50163ff5eaad45c4156491"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nibanks
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3mUNYj+9WY1YUfqLbGBS69nRy6aCP4AepJHh jyY1tTbwXdnUIr5reatuyqSy+zjwmIwWmJWdl2L06yIGOdGJEv853oeurHgx8F4TgBBmDSEivl2sTQ UIXVFiOzIA+4KuQCI4vtUwNig3V0VNxtgUFhOnVovxKx8Vwz8YBEhLP/Dq08cUSbOz8xdliLJG6OV2 Y=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/WoDkF0uYU6nki1KfnYzHKFRnhDg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Feb 2019 15:18:32 -0000

nibanks commented on this pull request.



> @@ -5012,6 +5020,44 @@ Reason Phrase:
   This SHOULD be a UTF-8 encoded string {{!RFC3629}}.
 
 
+## KEYS_READY Frame {#frame-keys-ready}
+
+An endpoint sends a KEYS_READY frame (type=0x1e) to signal that it has installed
+keys for reading and writing packets.  Receipt of this frame in a packet
+indicates that all earlier keys can be safely discarded.

I personally prefer the immediate discarding of keys and implicit ACKs.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2237#discussion_r256441433

v2.23.0 | Report a Bug | By Email