Re: [quicwg/base-drafts] Describe QPACK Feedback mechanisms (#1410)
afrind <notifications@github.com> Mon, 04 June 2018 08:45 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 235271243F3 for <quic-issues@ietfa.amsl.com>; Mon, 4 Jun 2018 01:45:37 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Mpl2jWo8fPcO for <quic-issues@ietfa.amsl.com>; Mon, 4 Jun 2018 01:45:34 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 39BD7124B18 for <quic-issues@ietf.org>; Mon, 4 Jun 2018 01:45:34 -0700 (PDT)
Date: Mon, 04 Jun 2018 01:45:33 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1528101933; bh=iqUyryX1fcSMqW4c4+sBoMtT9lwLLz+UZlgZlBEA0EQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=UWh24sbbzmwePPUKvwNEwx92I6WA5ouwcm+0B/k36/083sPrvs8HcRK68J5ZeuONA V4uSKJxpnXlNUw2XXanCRq+j8r97JgihEOEv9AzJFPe6X+csMu7u4NQ91jTqJL1x8G Xi8rIkoxsuqCAvvwu1ee2iDgzLFeRVnS7Vd9hM+4=
From: afrind <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abfcc153f472c53c0a558af32138223838ae3975c092cf00000001172cbe2d92a169ce139917f8@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1410/review/125472428@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1410@github.com>
References: <quicwg/base-drafts/pull/1410@github.com>
Subject: Re: [quicwg/base-drafts] Describe QPACK Feedback mechanisms (#1410)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b14fc2d91fea_3fd62aac7ae24f546403f7"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: afrind
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/WqVjqxH0qvy6B5ml7wjmsciPk_g>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Jun 2018 08:45:37 -0000
afrind commented on this pull request. > +The decoder stream signals key events at the decoder that permit the encoder to +track the decoder's state. These events are: + +- Successful processing of a header block +- Abandonment of a stream which might have remaining header blocks +- Receipt of new dynamic table entries + +Regardless of whether a header block contained blocking references, the +knowledge that it was processed successfully permits the encoder to avoid +evicting entries while references remain outstanding; see {{blocked-eviction}}. +When a stream is reset or abandoned, the indication that these header blocks +will never be processed serves a similar function. + +For the encoder to identify which dynamic table entries can be safely used +without a stream becoming blocked, the encoder tracks the Largest Known Received +absolute index in the decoder's state. "in the decoder's state" sounds kind of weird. Maybe "the encoder tracks the absolute index of the decoder's Largest Known Received entry. > +- Successful processing of a header block +- Abandonment of a stream which might have remaining header blocks +- Receipt of new dynamic table entries + +Regardless of whether a header block contained blocking references, the +knowledge that it was processed successfully permits the encoder to avoid +evicting entries while references remain outstanding; see {{blocked-eviction}}. +When a stream is reset or abandoned, the indication that these header blocks +will never be processed serves a similar function. + +For the encoder to identify which dynamic table entries can be safely used +without a stream becoming blocked, the encoder tracks the Largest Known Received +absolute index in the decoder's state. + +When blocking references are permitted, the encoder uses acknowledgement of +header blocks for this purpose. If a header block was potentially blocking, the "for this purpose" reads ambiguously to me. > +- Abandonment of a stream which might have remaining header blocks +- Receipt of new dynamic table entries + +Regardless of whether a header block contained blocking references, the +knowledge that it was processed successfully permits the encoder to avoid +evicting entries while references remain outstanding; see {{blocked-eviction}}. +When a stream is reset or abandoned, the indication that these header blocks +will never be processed serves a similar function. + +For the encoder to identify which dynamic table entries can be safely used +without a stream becoming blocked, the encoder tracks the Largest Known Received +absolute index in the decoder's state. + +When blocking references are permitted, the encoder uses acknowledgement of +header blocks for this purpose. If a header block was potentially blocking, the +successful processing of the block by the decoder implies that all dynamic table receipt of a header acknowledgement implies this -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1410#pullrequestreview-125472428
- Re: [quicwg/base-drafts] Describe QPACK Feedback … afrind
- Re: [quicwg/base-drafts] Describe QPACK Feedback … Mike Bishop
- Re: [quicwg/base-drafts] Describe QPACK Feedback … Mike Bishop
- Re: [quicwg/base-drafts] Describe QPACK Feedback … afrind
- Re: [quicwg/base-drafts] Describe QPACK Feedback … Martin Thomson
- Re: [quicwg/base-drafts] Describe QPACK Feedback … Mike Bishop
- Re: [quicwg/base-drafts] Describe QPACK Feedback … Mike Bishop
- [quicwg/base-drafts] Describe QPACK Feedback mech… Mike Bishop
- Re: [quicwg/base-drafts] Describe QPACK Feedback … Mike Bishop
- Re: [quicwg/base-drafts] Describe QPACK Feedback … Mike Bishop
- Re: [quicwg/base-drafts] Describe QPACK Feedback … afrind