Re: [quicwg/base-drafts] Remove some cruft from packet size section (#3262)

Nick Banks <notifications@github.com> Tue, 19 November 2019 01:02 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7814E1201EF for <quic-issues@ietfa.amsl.com>; Mon, 18 Nov 2019 17:02:21 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0Z9NWhQyZY_M for <quic-issues@ietfa.amsl.com>; Mon, 18 Nov 2019 17:02:19 -0800 (PST)
Received: from out-17.smtp.github.com (out-17.smtp.github.com [192.30.252.200]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B4228120143 for <quic-issues@ietf.org>; Mon, 18 Nov 2019 17:02:19 -0800 (PST)
Received: from github-lowworker-f045d1f.ac4-iad.github.net (github-lowworker-f045d1f.ac4-iad.github.net [10.52.19.54]) by smtp.github.com (Postfix) with ESMTP id 947456E0E53 for <quic-issues@ietf.org>; Mon, 18 Nov 2019 17:02:18 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1574125338; bh=JHuOiSv8g7oMhHdXjgSHX0aUH1wIlPbIzpUGNiCqtGY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=se/RaiW5O7msqFUIDREZE0RsZtsQvNzhF5lelkaKiSNftsjRLgOgZk8ovRfKzMxSO /7FOsfVenMj07pfIO6wmddL9/x8YtFqp/qbG+/vqLBOTf9i1WGDkULnQzrNVS0GZzJ gATGo77NKrbXOvOaKFXIx51HTlGgr0KlQBTwkNRU=
Date: Mon, 18 Nov 2019 17:02:18 -0800
From: Nick Banks <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2SYDEENKUOR2PHSO534BYZVEVBNHHB6RS4SQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3262/review/318727533@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3262@github.com>
References: <quicwg/base-drafts/pull/3262@github.com>
Subject: Re: [quicwg/base-drafts] Remove some cruft from packet size section (#3262)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dd33f1a83af3_b633ffc246cd9681343b9"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nibanks
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/WyUthS_RIT2Q7m_x_ra3ykSVDzs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Nov 2019 01:02:22 -0000

nibanks approved this pull request.

Everything looks good, except for the comment I have about already existing text.

>  A server MAY send a CONNECTION_CLOSE frame with error code PROTOCOL_VIOLATION in
-response to the first Initial packet it receives from a client if the UDP
-datagram is smaller than 1200 bytes. It MUST NOT send any other frame type in
-response, or otherwise behave as if any part of the offending packet was
-processed as valid.
+response to an Initial packet it receives from a client if the UDP datagram is
+smaller than 1200 bytes. It MUST NOT send any other frame type in response, or

I know it's not part of this PR, but why do we let what is essentially an unauthenticated packet to kill the connection? Shouldn't the packet just be dropped and ignored?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3262#pullrequestreview-318727533