Re: [quicwg/base-drafts] Identify streams unidirectional vs bidirectional based on stream ID (#872)

Martin Thomson <notifications@github.com> Wed, 18 October 2017 03:42 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3B8FA127005 for <quic-issues@ietfa.amsl.com>; Tue, 17 Oct 2017 20:42:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.018
X-Spam-Level:
X-Spam-Status: No, score=-2.018 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id d0TWhIAKIgta for <quic-issues@ietfa.amsl.com>; Tue, 17 Oct 2017 20:42:31 -0700 (PDT)
Received: from o7.sgmail.github.com (o7.sgmail.github.com [167.89.101.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 92A0C13202D for <quic-issues@ietf.org>; Tue, 17 Oct 2017 20:42:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=HFZ55eki5VYTbAdsN+4FxbkrG0Q=; b=kIiUT7N//3mPCl5L R5uBg0SEMdsnIFqk/A6Tz+t86KTq1LdQ+9Nwg67w4Inmp7TafGn5mfDUCTTY8IvP xE9nLBqWcmDwRG3WOmZoblyq383+lviq4Ci+079mjhdbgpGecntN4PPvBtzfiwyo tGlAw4LOm1Rm/wF18RcLSwOcK8o=
Received: by filter0238p1iad2.sendgrid.net with SMTP id filter0238p1iad2-1636-59E6CDA6-B 2017-10-18 03:42:30.476275891 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [192.30.253.16]) by ismtpd0019p1iad2.sendgrid.net (SG) with ESMTP id mMwCNQIkT6S8jp8eLge4pw for <quic-issues@ietf.org>; Wed, 18 Oct 2017 03:42:30.426 +0000 (UTC)
Date: Wed, 18 Oct 2017 03:42:30 +0000
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abcf92564b04d4d6d1a458b05a8fea723f43a242aa92cf0000000115fe8fa692a169ce0fd14a5e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/872/review/70090652@github.com>
In-Reply-To: <quicwg/base-drafts/pull/872@github.com>
References: <quicwg/base-drafts/pull/872@github.com>
Subject: Re: [quicwg/base-drafts] Identify streams unidirectional vs bidirectional based on stream ID (#872)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_59e6cda658cc7_1c1b83fe5c116af30337344"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3Hz0542O7TC4iI5JqUEaSjH9zkQqglVVyofB qGdU3hWkG376eJvj8okszX8q1mYuX82ATIYT/xrKexIm4wFseLgVOwEvkUN22h/EcRZH0SjhQnglJE KQBc5EPZExBQKv8qM7Jnxq8bWN4wijIwIc/oU/Tf/bRBnYQGTOU0V6K0Wa8RS0+ypKjL9s8rFbeNt9 M=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/X48uS105sjlWI1Hk4JFrw3eH0fY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Oct 2017 03:42:33 -0000

martinthomson commented on this pull request.



> @@ -2472,6 +2476,18 @@ corresponds to a stream which is allocated to it (i.e., odd-numbered for
 the client or even-numbered for the server) but which it has not yet
 created, it MUST close the connection with error code STREAM_STATE_ERROR.
 
+The second least significant bit differentiates between unidirectional streams
+and bidirectional streams. Unidirectional streams always have this bit set to
+1 and bidirectional streams have this bit set to 0. As a result the initial
+stream ID for various stream types is listed below:
+
+| Stream ID   | Type                          |
+|:------------|:------------------------------|
+| 0x01        | Client Bidirectional          |
+| 0x02        | Server Bidirectional          |
+| 0x03        | Client Unidirectional         |
+| 0x04        | Server Unidirectional         |

Hmm, this table is wrong too.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/872#pullrequestreview-70090652