Re: [quicwg/base-drafts] Remove mandatory in-order delivery (#1070)

jpinner-lyft <notifications@github.com> Thu, 25 January 2018 03:25 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 397DE12E042 for <quic-issues@ietfa.amsl.com>; Wed, 24 Jan 2018 19:25:17 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.625
X-Spam-Level:
X-Spam-Status: No, score=-0.625 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HYuwuL_QCJ6N for <quic-issues@ietfa.amsl.com>; Wed, 24 Jan 2018 19:25:16 -0800 (PST)
Received: from o3.sgmail.github.com (o3.sgmail.github.com [192.254.112.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0D10612711E for <quic-issues@ietf.org>; Wed, 24 Jan 2018 19:25:15 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=nPM5qRs14Es8OzS/QdNRjzZi62M=; b=u346QFNRYoP730L2 OkeCLn45nQgp+T7vv6SWKSmVEHwsS6TMJVAfy0pPDgXmuFcmsucB3DJn5EhY79Tw vQVwpHaUVdJpltZCY/5b6c5ftvEKCe1/GdOnEBkgxgQdjGN0dTxBWWy0lEnzIGYm QBeowTtzAitP83MvhwOv7LbyId4=
Received: by filter0075p1iad2.sendgrid.net with SMTP id filter0075p1iad2-13901-5A694E1A-15 2018-01-25 03:25:14.924637958 +0000 UTC
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [192.30.253.17]) by ismtpd0003p1iad1.sendgrid.net (SG) with ESMTP id I6HQ3P8SRbeFn75ecN5XAg for <quic-issues@ietf.org>; Thu, 25 Jan 2018 03:25:14.717 +0000 (UTC)
Date: Thu, 25 Jan 2018 03:25:15 +0000
From: jpinner-lyft <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abffb1138208aa39ccade4ce85b32021e0e7bd365b92cf000000011681101a92a169ce115eeabc@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1070/review/91404004@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1070@github.com>
References: <quicwg/base-drafts/pull/1070@github.com>
Subject: Re: [quicwg/base-drafts] Remove mandatory in-order delivery (#1070)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5a694e1a99884_55023fbfd1e3ef38986a4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: jpinner-lyft
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak10QCyWRMIhGbpF8HKDKTPX8htQIDoLeefl8V zZvBmqdrVmjgmHRTLneKfiM0kfuvZSG/hNBPMhlR2hVnhdU1RSILG+r0poq47bx0mXJGvkkw/MM+Yj gKJz9Tn2+Bs4xisbJcGErqtJLeRM7SIkkhcQmEl9VGw3vHnIuMHQWL2P0cA+F1kdGWOgXTDLXWhKjZ E=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/XEtmlLo6P3EzYcJB16-l-l4IGkc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Jan 2018 03:25:17 -0000

jpinner-lyft commented on this pull request.



> @@ -3266,7 +3267,7 @@ sender or during delivery to the application at the receiver.
 
 When new data is to be sent on a stream, a sender MUST set the encapsulating
 STREAM frame's offset field to the stream offset of the first byte of this new
-data.  The first byte of data that is sent on a stream has the stream offset 0.
+data.  The first byte of data that is sent on a stream has an offset of 0.

I think this should read `The first byte of data on a stream has an offset of 0.`

What you send first depends on what your receive and if you're a proxy you don't want to have to necessarily buffer data until you receive offset 0 just to forward it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1070#pullrequestreview-91404004