[quicwg/base-drafts] b84d5c: lost_pn can no longer be negative

ianswett <noreply@github.com> Mon, 15 April 2019 15:38 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 978501203F6 for <quic-issues@ietfa.amsl.com>; Mon, 15 Apr 2019 08:38:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.002
X-Spam-Level:
X-Spam-Status: No, score=-7.002 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bfW9ZbkI_snP for <quic-issues@ietfa.amsl.com>; Mon, 15 Apr 2019 08:38:15 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 758041203EB for <quic-issues@ietf.org>; Mon, 15 Apr 2019 08:38:15 -0700 (PDT)
Date: Mon, 15 Apr 2019 08:38:14 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1555342694; bh=0ct2oxOA6gDwLkNHn2zytSQVmOFT6KEwAMvF4a0XcYc=; h=Date:From:To:Subject:From; b=RcLtlMMldeUn4DdCUEkR3bhuqEYdwetFyw7p22AxQvA00Y+aHXZNUdq0aHZs4G5l3 CT2uPDkP6ile0okALK3dBiGyA1MdJ0/Pgxkwfh8c7V4m30eQBVZ82jZUcgZDtF5/mQ I/12/HueoDoyBF+7Y1LEOejRKMyPwMni5YJEyVGM=
From: ianswett <noreply@github.com>
To: quic-issues@ietf.org
Message-ID: <quicwg/base-drafts/push/refs/heads/ianswett-lost-pn/000000-b84d5c@github.com>
Subject: [quicwg/base-drafts] b84d5c: lost_pn can no longer be negative
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-Auto-Response-Suppress: All
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/XP9DnwblNHNEXgbWOYbhl-9b9W0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Apr 2019 15:38:18 -0000

  Branch: refs/heads/ianswett-lost-pn
  Home:   https://github.com/quicwg/base-drafts
  Commit: b84d5cba6993fc8158d14df876ba12ca14ec7312
      https://github.com/quicwg/base-drafts/commit/b84d5cba6993fc8158d14df876ba12ca14ec7312
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2019-04-15 (Mon, 15 Apr 2019)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  lost_pn can no longer be negative

And 0 is a valid packet number, so defaulting largest_acked_packet to 0 is inherently incorrect.

Fixes #2611