Re: [quicwg/base-drafts] Define stream limits as counts (#1906)

Martin Thomson <notifications@github.com> Thu, 25 October 2018 23:55 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6D66B12F1A5 for <quic-issues@ietfa.amsl.com>; Thu, 25 Oct 2018 16:55:25 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hqYP8CS2THtR for <quic-issues@ietfa.amsl.com>; Thu, 25 Oct 2018 16:55:23 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 64885128D0C for <quic-issues@ietf.org>; Thu, 25 Oct 2018 16:55:23 -0700 (PDT)
Date: Thu, 25 Oct 2018 16:55:21 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1540511721; bh=L/Ma7AqW/91YmnMuIdhP0LUvSRCV3UnALstDJHPnn2Q=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=FUrqLfcO8mp15HCozZpMqAIz0eIKpDyvl9YMsfyS28YqSedq66hgy9BofFSmwAgJj Mv9voHhPma19axBaGwjmI9N4vt46fBH/hJssklRHasW24vO6VN5PJL86bSna6DOaTv by/tj1AunEUdEJjWyGobhcTELUE/F/iAcQfcKfYE=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abc3117c9468a44eb7d807ec22fa1c907e79fc998392cf0000000117ea19e992a169ce1646c612@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1906/review/168628485@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1906@github.com>
References: <quicwg/base-drafts/pull/1906@github.com>
Subject: Re: [quicwg/base-drafts] Define stream limits as counts (#1906)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bd257e9b87c2_3d5e3fefbccd45c431920de"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/XQj96WNYVJH1WRmrlqJedMxC1XU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Oct 2018 23:55:25 -0000

martinthomson commented on this pull request.



>  
-The maximum stream ID is specific to each endpoint and applies only to the peer
-that receives the setting. That is, clients specify the maximum stream ID the
-server can initiate, and servers specify the maximum stream ID the client can
-initiate.  Each endpoint may respond on streams initiated by the other peer,
-regardless of whether it is permitted to initiate new streams.
+The stream limit is specific to each endpoint and applies only to the peer that
+receives the setting. That is, clients limit the number of streams the server

I agree that this isn't great, but it's an artifact of encoding stream type in the ID.  A decision I really don't want to revisit, BTW.

Given that the number of streams can be very easily determined from the ID with `(id+3)/4`, or the test for whether an stream can be opened is `id/4 >= limit`, I think that this is quite workable.

I've tweaked the text you point at.  Hopefully this is clearer.

>  
-The STREAM_ID_BLOCKED frame ({{frame-stream-id-blocked}}) can be
-used to signal a shortage of available streams. Implementations will likely
-want to increase the maximum stream ID as peer-initiated streams close.
+The STREAMS_BLOCKED frame ({{frame-streams-blocked}}) can be used to signal a
+shortage of available streams. Implementations could use this as a signal to

Thanks.  I struggled with that.

>  
-The STREAM_ID_BLOCKED frame ({{frame-stream-id-blocked}}) can be
-used to signal a shortage of available streams. Implementations will likely
-want to increase the maximum stream ID as peer-initiated streams close.

Yeah, I think that I might restore this, but attach it to the paragraph above.

>  
-Loss or reordering can mean that a MAX_STREAM_ID frame can be received which
+Loss or reordering can mean that a MAX_STREAMS frame can be received which

Fixed better, also used "endpoint" rather than client.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1906#discussion_r228369685