Re: [quicwg/base-drafts] QPACK [editorial] Update text to include both criteria of "blocking entry". (#2937)

Bence Béky <notifications@github.com> Thu, 15 August 2019 16:32 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A29641200CC for <quic-issues@ietfa.amsl.com>; Thu, 15 Aug 2019 09:32:54 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.998
X-Spam-Level:
X-Spam-Status: No, score=-7.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FROM_EXCESS_BASE64=0.001, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I61hYO4gSgBm for <quic-issues@ietfa.amsl.com>; Thu, 15 Aug 2019 09:32:51 -0700 (PDT)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A9C541200BA for <quic-issues@ietf.org>; Thu, 15 Aug 2019 09:32:51 -0700 (PDT)
Date: Thu, 15 Aug 2019 09:32:50 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1565886770; bh=y3IDrwdtaAs/aoHkmYEDe55FPTxudRTGEu5FXz7GcOk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Awwu/EvI0yiulXrycCInlm8arjxI3rPCtVf7RudVyzwI5dk3SQmwVj/cLswdiVD6O vq491K8bYKP0CtWq+o2VDGFug0seReHVwv6sZUOaPMc5psA8Z3dczw/Y/NwA4EZeS7 0sExMPat9FohiMwxyRq6EULccff8tVZ4B4Xroci0=
From: Bence Béky <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7W2VINRPPHLSEYR5F3MK53FEVBNHHBYU23SE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2937/review/275535980@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2937@github.com>
References: <quicwg/base-drafts/pull/2937@github.com>
Subject: Re: [quicwg/base-drafts] QPACK [editorial] Update text to include both criteria of "blocking entry". (#2937)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d558932bbf22_632b3fe2268cd960321121"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: bencebeky
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/XR0e1EUwBAHmwdSRcBRmgnvw9yo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Aug 2019 16:32:55 -0000

bencebeky commented on this pull request.



> @@ -229,8 +229,9 @@ table that it will emit a reference for.  As new entries are inserted, the
 encoder increases the draining index to maintain the section of the table that
 it will not reference.  If the encoder does not create new references to entries
 with an absolute index lower than the draining index, the number of
-unacknowledged references to those entries will eventually become zero, allowing
-them to be evicted.
+unacknowledged references to every such entry will eventually become zero,
+allowing it to be evicted provided that its insertion has been acknowledged by
+the decoder.

Ah, let me just revert the change to this paragraph.  No matter how I try to reword it, mentioning acknowledgement of the insertion always leaves it more confusing that the original text.  After all, if the number of unacknowledged references _becomes_ zero, that means it was not zero beforehand, therefore the encoder knows for sure that the insertion has been processed by the decoder.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2937#discussion_r314393645