Re: [quicwg/base-drafts] Allow not creating QPACK codec streams (#2529)

Dmitri Tikhonov <notifications@github.com> Wed, 20 March 2019 18:46 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 441A01311C1 for <quic-issues@ietfa.amsl.com>; Wed, 20 Mar 2019 11:46:29 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.001
X-Spam-Level:
X-Spam-Status: No, score=-3.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uE2QLU9S76vj for <quic-issues@ietfa.amsl.com>; Wed, 20 Mar 2019 11:46:27 -0700 (PDT)
Received: from o4.sgmail.github.com (o4.sgmail.github.com [192.254.112.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1B6481311B3 for <quic-issues@ietf.org>; Wed, 20 Mar 2019 11:46:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=oHmtt7Axd9kL/+Mo99KuPQg5HNE=; b=ofgJrOxkygZNMppm 1rdMmwVgj0Splhmb1bIeee6iItZ4OPq7KNSZD83LIk5HQuTjF7ySpjm9gSMB3Z64 XVENRkXUeZmzf1xOKIZakmZ/A07BfwL5X0JI8iaNLSLUFuDCB7eNMiDFwHiAcbKN Y640BBoXa+JCE81GM2sxWfIMXWY=
Received: by filter1071p1las1.sendgrid.net with SMTP id filter1071p1las1-19149-5C928A7C-2F 2019-03-20 18:46:20.514953399 +0000 UTC m=+371427.764611174
Received: from github-lowworker-3c598a3.cp1-iad.github.net (unknown [192.30.252.43]) by ismtpd0002p1iad1.sendgrid.net (SG) with ESMTP id XeMbSpqQRyCkIPYL5kzSXQ for <quic-issues@ietf.org>; Wed, 20 Mar 2019 18:46:20.419 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-3c598a3.cp1-iad.github.net (Postfix) with ESMTP id 65F50A802AF for <quic-issues@ietf.org>; Wed, 20 Mar 2019 11:46:20 -0700 (PDT)
Date: Wed, 20 Mar 2019 18:46:20 +0000
From: Dmitri Tikhonov <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abf7c0b581a6df93a715daa77d1e23e3035fb32ff192cf0000000118aa4c7c92a169ce1931c3e6@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2529/review/216915969@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2529@github.com>
References: <quicwg/base-drafts/pull/2529@github.com>
Subject: Re: [quicwg/base-drafts] Allow not creating QPACK codec streams (#2529)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c928a7c641ad_35953ff824cd45b8189128"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: dtikhonov
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3AVfPt7m2/hvNA3c2JF7+PQsNpaNbPliLEnv DtJAXjbFJMfu3EVBtMH+m38WOq7thMUisr3AKqhfuk9Q6+fNEfksqoAF+78b9c85ZHewCVhC3y8k2r 3q9EzNBYHnKP7XLtFs958IKA24IUGr1VtAkKg/S9lEvkghFnxGJ0MY4ykfjOdP1D9OtoDKdp9VYsT+ s=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/XTVBFfP-WU5lLX5JOJgZp8Dj2Rk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Mar 2019 18:46:29 -0000

dtikhonov commented on this pull request.



>  HTTP_WRONG_STREAM_COUNT. These streams MUST NOT be closed. Closure of either
 unidirectional stream type MUST be treated as a connection error of type
 HTTP_CLOSED_CRITICAL_STREAM.
 
+An endpoint MAY avoid creating its own encoder stream if the maximum size of
+the dynamic table permitted by the peer is zero.
+
+An endpoint MAY avoid creating its own decoder stream if the maximum size of
+its own dynamic table is zero.
+
+An endpoint MUST allow its peer to create both encoder and decoder streams

> Hmmm, I think I was reading #2100 (comment) wrong.
> 
> But yeah, the **intention there was to disallow setting the uni streams limit to less than 3** in order to allow the other side to open all of their streams.

(Emphasis added)

I see how you get that from that comment by @MikeBishop:

> Discussed in Tokyo; do not require creating the streams, but creating them is not forbidden even if the setting prevents their use

But the "setting" refers to the QPACK settings -- namely, the size of the dynamic table -- and not to the stream limits.  Otherwise, how could it not be forbidden to create streams over the stream number limits specified by the peer?

I agree that more clarity is required.  My preference would be to allow the unidirectional stream limit to be set to 1 to allow just the HTTP Control Stream.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2529#discussion_r267493738