Re: [quicwg/base-drafts] use max_ack_delay = 0 before receving the TPs (#2646)

MikkelFJ <notifications@github.com> Wed, 24 April 2019 06:13 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F2643120154 for <quic-issues@ietfa.amsl.com>; Tue, 23 Apr 2019 23:13:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.597
X-Spam-Level:
X-Spam-Status: No, score=-6.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BkQzpdfaGPfz for <quic-issues@ietfa.amsl.com>; Tue, 23 Apr 2019 23:13:44 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B129412002E for <quic-issues@ietf.org>; Tue, 23 Apr 2019 23:13:44 -0700 (PDT)
Date: Tue, 23 Apr 2019 23:13:43 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1556086423; bh=PwfTr/GNB+jN2e4G+i8XaoJyIQ4dunyKdIoZmFZvBH4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Cl22UAf+aSKG5C9fAHc46wtbEEATK823cTl0bW9f6kdrK2G9U2VRnn/EZhDMnflHo mI0DGF1VJtMQhoTkfDW0rafoSx00JKl/xW2pcYKJbMpNNBmJk5ryfkyWyN8iNUVB67 diiOxXrSjTn6LcbmvezrBJyijOH0neav2tQVky+M=
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5V4J2IEOR2P2QCRSV2ZUYRPEVBNHHBUA7M3M@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2646/review/229914218@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2646@github.com>
References: <quicwg/base-drafts/pull/2646@github.com>
Subject: Re: [quicwg/base-drafts] use max_ack_delay = 0 before receving the TPs (#2646)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cbffe9797dfb_d263fcfb08cd95c10596ea"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/XVE13NwfesxkZwIUTeMRxZ1a3_0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Apr 2019 06:13:47 -0000

mikkelfj commented on this pull request.



> @@ -1028,9 +1029,9 @@ min_rtt:
 
 max_ack_delay:
 : The maximum amount of time by which the receiver intends to delay
-  acknowledgments, in milliseconds.  The actual ack_delay in a
-  received ACK frame may be larger due to late timers, reordering,
-  or lost ACKs.
+  acknowledgments. The value is initialized to 0, and updated when the peer's
+  transport parameters are received. The actual ACK Delay in a received ACK
+  frame may be larger due to late timers, reordering, or lost ACKs.

I think this text needs to clarify that the value is updated to the default 25ms if TPs are received with the max_ack_delay setting.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2646#discussion_r277967109