IETF Logo Mail Archive

Re: [quicwg/base-drafts] Do not allow ICMP PTB to increase PMTU (#2161)

Igor Lubashev <notifications@github.com> Fri, 14 December 2018 18:54 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 14520131254 for <quic-issues@ietfa.amsl.com>; Fri, 14 Dec 2018 10:54:06 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.459
X-Spam-Level:
X-Spam-Status: No, score=-9.459 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KKzTPVZ2aI5U for <quic-issues@ietfa.amsl.com>; Fri, 14 Dec 2018 10:54:04 -0800 (PST)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4B8DF13124A for <quic-issues@ietf.org>; Fri, 14 Dec 2018 10:54:04 -0800 (PST)
Date: Fri, 14 Dec 2018 10:54:02 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1544813642; bh=81y93luJmyy+1B1slJZe5Rmhs+kHbJVzffByOqB9n0o=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=qZqEUuLAmiYR04dGsercC0bVtl68BQeUA1XUz6F8ogNgQfkMlAzjIDdrWkZdv0oVx mmkfYQXIkI6mvDYqYUlWEItZ8OaITjzEygHqCoRckOLNfElcDVFIDCd1nszLdzAl4t 4tUoPPNHb8UaivjLtmNYduRoNLzKPhy1itVJz2yY=
From: Igor Lubashev <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab15bebe4f62e69bfd2d18358400cfff14818a049692cf00000001182bbe4a92a169ce174c2f88@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2161/review/185239563@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2161@github.com>
References: <quicwg/base-drafts/pull/2161@github.com>
Subject: Re: [quicwg/base-drafts] Do not allow ICMP PTB to increase PMTU (#2161)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c13fc4ac8b74_7123fcc714d45b820806e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: igorlord
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/XXgy3DEetRCdfhx9BSvKGEnuej0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Dec 2018 18:54:06 -0000

igorlord commented on this pull request.



> @@ -3139,7 +3139,8 @@ attacks that successfully guess the IP address 3-tuple and reduce the PMTU to a
 bandwidth-inefficient value.
 
 An endpoint MUST ignore an ICMP message that claims the PMTU has decreased below
-1280 bytes.
+1280 bytes.  And endpoint MUST ignore an ICMP message that attempts to increase
+PMTU, unless the ICMP message was received in response to a PMTU probe packet.

@gloinul, DPLPMTUD is not a requirement for QUIC.

This text was to apply to all implementations -- ones performing DPLPMTUD or traditional PMTUD or something else.  It is possible that we just reject this PR and assume people will follow directions specified in whatever PMTUD scheme they are implementing.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2161#discussion_r241854827

v2.23.0 | Report a Bug | By Email