Re: [quicwg/base-drafts] Use "Insert Count" rather than "Largest Reference" (#2111)

afrind <notifications@github.com> Thu, 10 January 2019 00:37 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 90EE9131027 for <quic-issues@ietfa.amsl.com>; Wed, 9 Jan 2019 16:37:24 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -12.552
X-Spam-Level:
X-Spam-Status: No, score=-12.552 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eQiNLq_VGwVt for <quic-issues@ietfa.amsl.com>; Wed, 9 Jan 2019 16:37:22 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8A524130E1C for <quic-issues@ietf.org>; Wed, 9 Jan 2019 16:37:22 -0800 (PST)
Date: Wed, 09 Jan 2019 16:37:21 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1547080641; bh=ATgatdnrb9bj51REy5QlbF4tz2YSgir0JgQe9PisuHI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=mjMSNv8veQwRPRZJ6ICcrqqm0SgkRswF6eWRZ+w4Iuw5uyLr7w/vMnqP9G5/PHmXO PK+OAoqGZqO3yA38ltkx5N79cVhc4s7HCcX+VU7T+Y3Exy35DzibHjEeam2jZzeV9W trVqN92JlBa8Q85ho0dSqYA6DwPEMcu7LJKtLTLM=
From: afrind <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abf8abd6e98a01e937682cb7601d337b3ffe57cbe492cf00000001184e55c192a169ce17392ee3@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2111/review/191003748@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2111@github.com>
References: <quicwg/base-drafts/pull/2111@github.com>
Subject: Re: [quicwg/base-drafts] Use "Insert Count" rather than "Largest Reference" (#2111)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c3693c17a54b_11833fb762ed45b41025eb"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: afrind
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/XYkdHkNQ8vdan7CVDSabaFkwNvw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Jan 2019 00:37:24 -0000

afrind commented on this pull request.



>      +---+-----+-----+-----+-------+
-    | n | n-1 | n-2 | ... |  d+1  |  Absolute Index
+    | n | n-1 | n-2 | ... |   d   |  Absolute Index

If the absolute index is 0 based, then shouldn't the most recent entry be 'n - 1'?.  Eg: if Insert Count is 1 then the entry's absolute index is 0.

>      +---+-----+-----+-----+-----+
-    | n | n-1 | n-2 | ... | d+1 |  Absolute Index
+    | n | n-1 | n-2 | ... |  d  |  Absolute Index

Same here

> @@ -708,17 +726,17 @@ become blocked, as described in {{state-synchronization}}.
 {:#fig-size-sync title="Table State Synchronize"}

The above table still uses 'Insert Count', which might confuse some readers now that we've defined this term above to mean something else.  What this instruction sends is a Insert Count Delta, or something?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2111#pullrequestreview-191003748