Re: [quicwg/base-drafts] change the ack delay exponent to an ack delay multiplier (#2679)
Martin Thomson <notifications@github.com> Thu, 09 May 2019 05:02 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 68897120189 for <quic-issues@ietfa.amsl.com>; Wed, 8 May 2019 22:02:29 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.392
X-Spam-Level:
X-Spam-Status: No, score=-1.392 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id O-D-o5u055Wz for <quic-issues@ietfa.amsl.com>; Wed, 8 May 2019 22:02:28 -0700 (PDT)
Received: from out-17.smtp.github.com (out-17.smtp.github.com [192.30.252.200]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3016E120264 for <quic-issues@ietf.org>; Wed, 8 May 2019 22:02:28 -0700 (PDT)
Date: Wed, 08 May 2019 22:02:27 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1557378147; bh=Xum+Ian96AHcenFixSD5G/lEKUKOrlMbSpiWLZsf1so=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=vNWe6+Um+UvMy6J8V3VW5EOSxlmCeudy5yv5lai8LQAQh5Yp1lkdo3c6eTTU0NxqP reWnJhVuOOsIvWIXfyDRZY7bBD0EdGDMH5l65T2t+nPmRh+EOZxBv0nZfAkgq/i/qp 99JL/JC6EaME6A+vJk5qgxptXaQ1c5YJHsf/DIC8=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYU7B4QGBWVQ2QFY5524DTOHEVBNHHBUWHC24@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2679/review/235399785@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2679@github.com>
References: <quicwg/base-drafts/pull/2679@github.com>
Subject: Re: [quicwg/base-drafts] change the ack delay exponent to an ack delay multiplier (#2679)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cd3b46343a02_115a3ff0170cd9644823c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Xf-kIuRqf25tcjzoKJw9yW--1_0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 09 May 2019 05:02:30 -0000
martinthomson commented on this pull request.
>
-: The ACK delay exponent is an integer value indicating an
- exponent used to decode the ACK Delay field in the ACK frame ({{frame-ack}}).
- If this value is absent, a default value of 3 is assumed (indicating a
- multiplier of 8). Values above 20 are invalid.
+: The ACK delay multiplier is an integer value indicating a multiplier used to
+ decode the ACK Delay field in the ACK frame ({{frame-ack}}). If this value is
+ absent, a default value of 10 (corresponding to a resolution of 10
+ microseconds)is assumed. Values above 1,000,000 (corresponding to a resolution
+ of 1 second) are invalid.
It might be better to leave the multiplier at 1 rather than pick a value.
Also, I assume that we want to prohibit 0.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2679#pullrequestreview-235399785
- [quicwg/base-drafts] change the ack delay exponen… Marten Seemann
- Re: [quicwg/base-drafts] change the ack delay exp… Kazuho Oku
- Re: [quicwg/base-drafts] change the ack delay exp… Martin Thomson
- Re: [quicwg/base-drafts] change the ack delay exp… Martin Thomson
- Re: [quicwg/base-drafts] change the ack delay exp… MikkelFJ
- Re: [quicwg/base-drafts] change the ack delay exp… Marten Seemann
- Re: [quicwg/base-drafts] change the ack delay exp… Marten Seemann
- Re: [quicwg/base-drafts] change the ack delay exp… MikkelFJ
- Re: [quicwg/base-drafts] change the ack delay exp… Martin Thomson
- Re: [quicwg/base-drafts] change the ack delay exp… Martin Thomson
- Re: [quicwg/base-drafts] change the ack delay exp… Martin Thomson