Re: [quicwg/base-drafts] Early CONNECTION_CLOSE fixes (#3440)

ekr <notifications@github.com> Sat, 07 March 2020 23:00 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B90363A1C42 for <quic-issues@ietfa.amsl.com>; Sat, 7 Mar 2020 15:00:09 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.482
X-Spam-Level:
X-Spam-Status: No, score=-1.482 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kOsEuTYgl583 for <quic-issues@ietfa.amsl.com>; Sat, 7 Mar 2020 15:00:08 -0800 (PST)
Received: from out-15.smtp.github.com (out-15.smtp.github.com [192.30.254.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 802CB3A1C4C for <quic-issues@ietf.org>; Sat, 7 Mar 2020 15:00:08 -0800 (PST)
Date: Sat, 07 Mar 2020 15:00:07 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1583622008; bh=cLDZ5LHTMbtONyZpRIGnrXWBmX4bqDe1QxI40BShHM0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=iCXRiZYSjsvB0mxntpr1MbDZuvyiBhffEpNBvlk82QHWXW1DaLzQtdah2wleo6Lpj GL2o9zAqQUGke5HhO75TIzbdwJxSoaEHiuBO9X1Ek3FqeVYsJFoWyUXCTz4OUO3NFn r5NtJLvz0OSQxSao/07xen4KIvYqhXxE3Ki2vk0I=
From: ekr <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7CCYAOXWA4VQ7MNBV4OAEHPEVBNHHCC4MTBY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3440/review/370793486@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3440@github.com>
References: <quicwg/base-drafts/pull/3440@github.com>
Subject: Re: [quicwg/base-drafts] Early CONNECTION_CLOSE fixes (#3440)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e6427779ea55_2c473f9e0cecd9682122ec"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ekr
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/XhXUaO8sscUD9g9OlcZ_53EIirw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 07 Mar 2020 23:00:20 -0000

ekr commented on this pull request.



>  
-- CONNECTION_CLOSE frames signaling application errors (type 0x1d) MUST only be
-  sent in packets at the 1-RTT encryption level.
+- ACK frames MAY appear in any packet number space, but can only acknowledge
+  packets which appeared in that packet number space.

This text is weird in light of the following graf that says that ACK is not permitted in 0-RTT. I would add a parenthetical "(however, as noted below, it is not possible for ACK frames to be sent in 0-RTT)"

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3440#pullrequestreview-370793486