Date: Mon, 18 Jun 2018 11:53:57 -0700
From: Igor Lubashev <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4abfb8488d83ac850fba8e7c81962b4f9727feb68c792cf00000001173fc1c592a169ce13a079ba@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1412/review/129693065@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1412@github.com>
References: <quicwg/base-drafts/pull/1412@github.com>
Subject: Re: [quicwg/base-drafts] Updated ICMP PMTU section (#1412)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5b27ffc590f08_2b3d3fbd4257cf80100064";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/XlcJUKInZs6eTQyndXpps4tND0M>


----==_mimepart_5b27ffc590f08_2b3d3fbd4257cf80100064
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

igorlord commented on this pull request.



> @@ -3157,9 +3157,9 @@ header, protected payload, and any authentication fields.
 All QUIC packets SHOULD be sized to fit within the estimated PMTU to avoid IP
 fragmentation or packet drops. To optimize bandwidth efficiency, endpoints
 SHOULD use Packetization Layer PMTU Discovery ({{!PLPMTUD=RFC4821}}).  Endpoints
-MAY use PMTU Discovery ({{!PMTUDv4=RFC1191}}, {{!PMTUDv6=RFC8201}}) for
-detecting the PMTU, setting the PMTU appropriately, and storing the result of
-previous PMTU determinations.
+MAY use classical PMTU Discovery ({{!PMTUDv4=RFC1191}}, {{!PMTUDv6=RFC8201}})

How strongly do you feel against word "classical"?  It is used in other RFCs for the purpose I am using it here.  See https://tools.ietf.org/html/rfc4821 and https://tools.ietf.org/html/rfc5320.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1412#discussion_r196187281
----==_mimepart_5b27ffc590f08_2b3d3fbd4257cf80100064
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@igorlord</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/1412#discussion_r196187281">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; @@ -3157,9 +3157,9 @@ header, protected payload, and any authentication fields.
 All QUIC packets SHOULD be sized to fit within the estimated PMTU to avoid IP
 fragmentation or packet drops. To optimize bandwidth efficiency, endpoints
 SHOULD use Packetization Layer PMTU Discovery ({{!PLPMTUD=RFC4821}}).  Endpoints
-MAY use PMTU Discovery ({{!PMTUDv4=RFC1191}}, {{!PMTUDv6=RFC8201}}) for
-detecting the PMTU, setting the PMTU appropriately, and storing the result of
-previous PMTU determinations.
+MAY use classical PMTU Discovery ({{!PMTUDv4=RFC1191}}, {{!PMTUDv6=RFC8201}})
</pre>
<p>How strongly do you feel against word "classical"?  It is used in other RFCs for the purpose I am using it here.  See <a href="https://tools.ietf.org/html/rfc4821" rel="nofollow">https://tools.ietf.org/html/rfc4821</a> and <a href="https://tools.ietf.org/html/rfc5320" rel="nofollow">https://tools.ietf.org/html/rfc5320</a>.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/1412#discussion_r196187281">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkqwzLpoFZaTRzOxe38G6tGvnVsqzbks5t9_dFgaJpZM4UaE4E">mute the thread</a>.<img src="https://github.com/notifications/beacon/AWbkq-njNKxYtAD9H8xiOz0gJXx9KvjOks5t9_dFgaJpZM4UaE4E.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/quicwg/base-drafts/pull/1412#discussion_r196187281","url":"https://github.com/quicwg/base-drafts/pull/1412#discussion_r196187281","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@igorlord commented on #1412"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/1412#discussion_r196187281"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@igorlord commented on 1412",
"sections": [
{
"text": "",
"activityTitle": "**Igor Lubashev**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@igorlord",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/quicwg/base-drafts/pull/1412#discussion_r196187281"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 342380036\n}"
}
],
"themeColor": "26292E"
}</script>
----==_mimepart_5b27ffc590f08_2b3d3fbd4257cf80100064--