Date: Mon, 27 Jul 2020 09:17:46 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK7YJNBHCIMY45KRNWV5FLPSVEVBNHHCN3BEFQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3868/review/455933568@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3868@github.com>
References: <quicwg/base-drafts/pull/3868@github.com>
Subject: Re: [quicwg/base-drafts] Prohibit reading 1-RTT before handshake
 complete (#3868)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5f1efe2aa7ccf_3d473fee0b6cd96c1479ae";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/XrDC14ZcAmJa1HaPi19oUS-nG-U>


----==_mimepart_5f1efe2aa7ccf_3d473fee0b6cd96c1479ae
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

@ianswett approved this pull request.



> @@ -1280,6 +1280,10 @@ A server could receive packets protected with 0-RTT keys prior to receiving a
 TLS ClientHello.  The server MAY retain these packets for later decryption in
 anticipation of receiving a ClientHello.
 
+A client generally receives 1-RTT keys at the same time as the handshake

```suggestion
A client typically receives 1-RTT keys at the same time as the handshake
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3868#pullrequestreview-455933568
----==_mimepart_5f1efe2aa7ccf_3d473fee0b6cd96c1479ae
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<p></p>=0D
<p><b>@ianswett</b> approved this pull request.</p>=0D
=0D
<hr>=0D
=0D
<p>In <a href=3D"https://github.com/quicwg/base-drafts/pull/3868#discussi=
on_r461007559">draft-ietf-quic-tls.md</a>:</p>=0D
<pre style=3D'color:#555'>&gt; @@ -1280,6 +1280,10 @@ A server could rece=
ive packets protected with 0-RTT keys prior to receiving a=0D
 TLS ClientHello.  The server MAY retain these packets for later decrypti=
on in=0D
 anticipation of receiving a ClientHello.=0D
 =0D
+A client generally receives 1-RTT keys at the same time as the handshake=
=0D
</pre>=0D
=E2=AC=87=EF=B8=8F Suggested change=0D
<pre style=3D"color: #555">-A client generally receives 1-RTT keys at the=
 same time as the handshake=0D
+A client typically receives 1-RTT keys at the same time as the handshake=
=0D
</pre>=0D
=0D
=0D
<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />You are receiving this because you are subscribed to this thre=
ad.<br />Reply to this email directly, <a href=3D"https://github.com/quic=
wg/base-drafts/pull/3868#pullrequestreview-455933568">view it on GitHub</=
a>, or <a href=3D"https://github.com/notifications/unsubscribe-auth/AFTOJ=
K3AVM6NQZHIGEYWBK3R5WSCVANCNFSM4OUG3SDQ">unsubscribe</a>.<img src=3D"http=
s://github.com/notifications/beacon/AFTOJK6XTI743QQ5WAG2MKLR5WSCVA5CNFSM4=
OUG3SD2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZ=
GODMWP5AA.gif" height=3D"1" width=3D"1" alt=3D"" /></p>=0D
<script type=3D"application/ld+json">[=0D
{=0D
"@context": "http://schema.org",=0D
"@type": "EmailMessage",=0D
"potentialAction": {=0D
"@type": "ViewAction",=0D
"target": "https://github.com/quicwg/base-drafts/pull/3868#pullrequestrev=
iew-455933568",=0D
"url": "https://github.com/quicwg/base-drafts/pull/3868#pullrequestreview=
-455933568",=0D
"name": "View Pull Request"=0D
},=0D
"description": "View this Pull Request on GitHub",=0D
"publisher": {=0D
"@type": "Organization",=0D
"name": "GitHub",=0D
"url": "https://github.com"=0D
}=0D
}=0D
]</script>=

----==_mimepart_5f1efe2aa7ccf_3d473fee0b6cd96c1479ae--