Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1])
 by ietfa.amsl.com (Postfix) with ESMTP id 9051212088E
 for <quic-issues@ietfa.amsl.com>; Thu,  6 Feb 2020 04:05:41 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level: 
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5
 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001,
 HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key)
 header.d=github.com
Received: from mail.ietf.org ([4.31.198.44])
 by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id khYl7bbBmYY0 for <quic-issues@ietfa.amsl.com>;
 Thu,  6 Feb 2020 04:05:40 -0800 (PST)
Received: from out-17.smtp.github.com (out-17.smtp.github.com [192.30.252.200])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by ietfa.amsl.com (Postfix) with ESMTPS id 11952120893
 for <quic-issues@ietf.org>; Thu,  6 Feb 2020 04:05:40 -0800 (PST)
Date: Thu, 06 Feb 2020 04:05:39 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
 s=pf2014; t=1580990739;
 bh=gAZ4o0BIJaHQN2yKX+28kcWkUYhCqoV5WupARX8p2g0=;
 h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID:
 List-Archive:List-Post:List-Unsubscribe:From;
 b=1FDi/71pSt7Y5l9AQ4obLqO4A902VoVl2tR/JSmbm/r2G2i+9IPqL8hAU+FZtNUHV
 OAWCw9YBh6QRActkIXlqUOIEvk7wEQPIUhcRzc31xo787y3PVIm94kWtan0VJ8jwF9
 u60rHPvokcA7E7GoGZ6ZhOkI/5f6oxlN0ypexIf8=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK2W25BB6R7TAIKFBXN4JEZZHEVBNHHCCZ7YJA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3426/review/354399838@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3426@github.com>
References: <quicwg/base-drafts/pull/3426@github.com>
Subject: Re: [quicwg/base-drafts] Clarify zero-length CIDs and
 active_connection_id_limit TP (#3426)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5e3c0113176ff_2a4b3fc4120cd9681210b7";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/XufIEY0ennltW7JPmzAF8ADiiys>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG
 <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Feb 2020 12:05:41 -0000


----==_mimepart_5e3c0113176ff_2a4b3fc4120cd9681210b7
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

martinthomson approved this pull request.

This is good.  Thanks for putting this together Nick.

> @@ -4697,11 +4697,11 @@ active_connection_id_limit (0x000e):
   to store. This value includes the connection ID received during the handshake,
   that received in the preferred_address transport parameter, and those received
   in NEW_CONNECTION_ID frames.
-  Unless a zero-length connection ID is being used, the value of the
-  active_connection_id_limit parameter MUST be no less than 2. If this
-  transport parameter is absent, a default of 2 is assumed.
-  When a zero-length connection ID is being used, the active_connection_id_limit
-  parameter MUST NOT be sent.
+  The value of the active_connection_id_limit parameter MUST be no less
+  than 2. If this transport parameter is absent, a default of 2 is assumed.
+  If an endpoint uses a zero-length connection ID, the
+  active_connection_id_limit value received from its peer is ignored and
+  not used.

```suggestion
  not used, as NEW_CONNECTION_ID frames can't be sent by a peer that opts for
  a zero-length connection ID.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3426#pullrequestreview-354399838
----==_mimepart_5e3c0113176ff_2a4b3fc4120cd9681210b7
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<p><b>@martinthomson</b> approved this pull request.</p>=0D
=0D
<p>This is good.  Thanks for putting this together Nick.</p><hr>=0D
=0D
<p>In <a href=3D"https://github.com/quicwg/base-drafts/pull/3426#discussi=
on_r375796681">draft-ietf-quic-transport.md</a>:</p>=0D
<pre style=3D'color:#555'>&gt; @@ -4697,11 +4697,11 @@ active_connection_=
id_limit (0x000e):=0D
   to store. This value includes the connection ID received during the ha=
ndshake,=0D
   that received in the preferred_address transport parameter, and those =
received=0D
   in NEW_CONNECTION_ID frames.=0D
-  Unless a zero-length connection ID is being used, the value of the=0D
-  active_connection_id_limit parameter MUST be no less than 2. If this=0D=

-  transport parameter is absent, a default of 2 is assumed.=0D
-  When a zero-length connection ID is being used, the active_connection_=
id_limit=0D
-  parameter MUST NOT be sent.=0D
+  The value of the active_connection_id_limit parameter MUST be no less=0D=

+  than 2. If this transport parameter is absent, a default of 2 is assum=
ed.=0D
+  If an endpoint uses a zero-length connection ID, the=0D
+  active_connection_id_limit value received from its peer is ignored and=
=0D
+  not used.=0D
</pre>=0D
=E2=AC=87=EF=B8=8F Suggested change=0D
<pre style=3D"color: #555">-  not used.=0D
+  not used, as NEW_CONNECTION_ID frames can't be sent by a peer that opt=
s for=0D
+  a zero-length connection ID.=0D
</pre>=0D
=0D
=0D
<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />You are receiving this because you are subscribed to this thre=
ad.<br />Reply to this email directly, <a href=3D"https://github.com/quic=
wg/base-drafts/pull/3426?email_source=3Dnotifications&amp;email_token=3DA=
FTOJK3NNABIWT33D4K42FDRBP4JHA5CNFSM4KQNOYIKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJ=
SXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCUP3MXQ#pullrequestreview-354399838=
">view it on GitHub</a>, or <a href=3D"https://github.com/notifications/u=
nsubscribe-auth/AFTOJKYBXFCM7A5DKTLDUVLRBP4JHANCNFSM4KQNOYIA">unsubscribe=
</a>.<img src=3D"https://github.com/notifications/beacon/AFTOJKYGPMRRRFUU=
66MZZZLRBP4JHA5CNFSM4KQNOYIKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWN=
FSXPKTDN5WW2ZLOORPWSZGOCUP3MXQ.gif" height=3D"1" width=3D"1" alt=3D"" /><=
/p>=0D
<script type=3D"application/ld+json">[=0D
{=0D
"@context": "http://schema.org",=0D
"@type": "EmailMessage",=0D
"potentialAction": {=0D
"@type": "ViewAction",=0D
"target": "https://github.com/quicwg/base-drafts/pull/3426?email_source=3D=
notifications\u0026email_token=3DAFTOJK3NNABIWT33D4K42FDRBP4JHA5CNFSM4KQN=
OYIKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOC=
UP3MXQ#pullrequestreview-354399838",=0D
"url": "https://github.com/quicwg/base-drafts/pull/3426?email_source=3Dno=
tifications\u0026email_token=3DAFTOJK3NNABIWT33D4K42FDRBP4JHA5CNFSM4KQNOY=
IKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCUP=
3MXQ#pullrequestreview-354399838",=0D
"name": "View Pull Request"=0D
},=0D
"description": "View this Pull Request on GitHub",=0D
"publisher": {=0D
"@type": "Organization",=0D
"name": "GitHub",=0D
"url": "https://github.com"=0D
}=0D
}=0D
]</script>=

----==_mimepart_5e3c0113176ff_2a4b3fc4120cd9681210b7--

