Re: [quicwg/base-drafts] Full (mostly) editorial pass (#1665)

Mike Bishop <notifications@github.com> Thu, 16 August 2018 18:07 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1FDD4130F17 for <quic-issues@ietfa.amsl.com>; Thu, 16 Aug 2018 11:07:20 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.01
X-Spam-Level:
X-Spam-Status: No, score=-3.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hjGlSC6ZtfS5 for <quic-issues@ietfa.amsl.com>; Thu, 16 Aug 2018 11:07:18 -0700 (PDT)
Received: from o11.sgmail.github.com (o11.sgmail.github.com [167.89.101.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 16EBE130E40 for <quic-issues@ietf.org>; Thu, 16 Aug 2018 11:07:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=xnpnmXP5IiA6RbtwlqTziqicthQ=; b=V33PzcfgFy7TGI7S twcz3N2F0muP48Esv0olLOi5G3+Oph2Ln4tHuq7mklSKgq4xFHrvganbJu9NLOmW eT78e93ROgTgkqBEkK0htKeE/MCcNP/Z5Y6axI0g8lwplArbX7vRMOPQ/5te6abP a+n8z2NAWijUa+v+oIPkXCvbZlY=
Received: by filter0908p1las1.sendgrid.net with SMTP id filter0908p1las1-7243-5B75BD55-29 2018-08-16 18:07:17.785132119 +0000 UTC m=+238735.380555015
Received: from github-lowworker14-cp1-prd.iad.github.net (unknown [192.30.252.38]) by ismtpd0002p1iad1.sendgrid.net (SG) with ESMTP id FNrQDiT-TKGLYolNH9jlBQ for <quic-issues@ietf.org>; Thu, 16 Aug 2018 18:07:17.642 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker14-cp1-prd.iad.github.net (Postfix) with ESMTP id 9C249DFA4E for <quic-issues@ietf.org>; Thu, 16 Aug 2018 11:07:17 -0700 (PDT)
Date: Thu, 16 Aug 2018 18:07:17 +0000
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abee4d117f5d20c6969265c4d3c102139cf251026692cf00000001178d7f5592a169ce14e9e22c@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1665/review/146960699@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1665@github.com>
References: <quicwg/base-drafts/pull/1665@github.com>
Subject: Re: [quicwg/base-drafts] Full (mostly) editorial pass (#1665)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b75bd5599f78_13ad3ffb940be620204187b"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0HtmkA7zRucG+NSUP+yU2gu7KYtk0a5/ymt6 64z3sU2v1b3skKNzE88ngRnkW6y4UIv4M4CCP6I3sBjIiP8qu+nb7qrfnRxBckGmUPUbuPApgz3hXg WW9Bq055+evcLua7BSigGsjFoBQKB8vYFtFRg/uuZBdhDxZ6RbE/O4+8ALxAJyKyKkaHY7Dkf5ATNT A=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Xwk96ZiZJTRQx4cwZ-vxCRSAkec>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Aug 2018 18:07:20 -0000

MikeBishop commented on this pull request.



>  a 1232 octet QUIC packet payload.  This includes overheads that reduce the space
 available to the cryptographic handshake protocol.
 
-The CRYPTO frame can be sent in different packet number spaces.  CRYPTO frames
+The CRYPTO frames can be sent in different packet number spaces.  CRYPTO frames

The original text, "The CRYPTO frame" talks about the CRYPTO frame as a unique type.  "CRYPTO frames" talks about the class of frames of that type.  Either would work here.  "The CRYPTO frames" sounds like a discrete set of frames which are being partitioned into the spaces.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1665#discussion_r210690517