Re: [quicwg/base-drafts] Idle timeout indicates you will timeout (#3099)

Kazuho Oku <notifications@github.com> Tue, 29 October 2019 01:09 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6B3BE120047 for <quic-issues@ietfa.amsl.com>; Mon, 28 Oct 2019 18:09:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id y6XSnXCu4Qyr for <quic-issues@ietfa.amsl.com>; Mon, 28 Oct 2019 18:08:58 -0700 (PDT)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C1550120033 for <quic-issues@ietf.org>; Mon, 28 Oct 2019 18:08:58 -0700 (PDT)
Received: from github-lowworker-2ef7ba1.ac4-iad.github.net (github-lowworker-2ef7ba1.ac4-iad.github.net [10.52.16.66]) by smtp.github.com (Postfix) with ESMTP id 814C41C0749 for <quic-issues@ietf.org>; Mon, 28 Oct 2019 18:08:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1572311337; bh=/TguZW1Gma3enO3hjrkNPtQYoM6c8G0Yw+DASGR/8KM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=lGmuKdvWPwiI4FCLDCasM5g4fg+LpxwErfXW8ovutMAMMdBRLxZ2sEcI7UYa4anDr UQWnm2x0ZVv9XS7Wj8s1p0ivMtOc4yOq0wb17eJgODo0Dqick/Y3fUcpwDHtOwke1i IhA/DqTWZCusmbEned8D6GGeroMIbldJeRGGalYA=
Date: Mon, 28 Oct 2019 18:08:57 -0700
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6TP4QVEAQZ2YXTM2N3YTB2TEVBNHHB4R4NZY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3099/review/308228705@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3099@github.com>
References: <quicwg/base-drafts/pull/3099@github.com>
Subject: Re: [quicwg/base-drafts] Idle timeout indicates you will timeout (#3099)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5db79129729dd_7cb43fc24aacd964787f3"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Xy1IqzVUgsj7Cti-MB6ChMSNNtU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Oct 2019 01:09:00 -0000

kazuho commented on this pull request.

I have suggestions for parts that did not read well to me, but otherwise LGTM.

>  
-: The idle timeout is a value in milliseconds that is encoded as an integer; see
-  ({{idle-timeout}}).  If this parameter is absent or zero then the idle
-  timeout is disabled.
+: The max idle timeout is a value in milliseconds that is encoded as an integer;
+  see ({{idle-timeout}}).  If this parameter is absent or zero then the idle
+  timeout is disabled unless the peer specifies a max idle timeout.

Maybe rephrase to: "Idle timeout is disabled when this parameter is absent or zero on both sides"?

> @@ -4593,11 +4595,12 @@ endpoints send PING frames without coordination can produce an excessive number
 of packets and poor performance.
 
 A connection will time out if no packets are sent or received for a period
-longer than the time specified in the idle_timeout transport parameter (see
-{{termination}}).  However, state in middleboxes might time out earlier than
-that.  Though REQ-5 in {{?RFC4787}} recommends a 2 minute timeout interval,
-experience shows that sending packets every 15 to 30 seconds is necessary to
-prevent the majority of middleboxes from losing state for UDP flows.
+longer than the time specified in the max_idle_timeout transport parameter

s/specified in/negotiated by using/?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3099#pullrequestreview-308228705