Re: [quicwg/base-drafts] Clarify text around preferred address (#3589)

Martin Thomson <notifications@github.com> Mon, 11 May 2020 00:04 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BA3023A0BDC for <quic-issues@ietfa.amsl.com>; Sun, 10 May 2020 17:04:58 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.101
X-Spam-Level:
X-Spam-Status: No, score=-3.101 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qIl8YmAWCpYZ for <quic-issues@ietfa.amsl.com>; Sun, 10 May 2020 17:04:56 -0700 (PDT)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7735D3A0BD5 for <quic-issues@ietf.org>; Sun, 10 May 2020 17:04:56 -0700 (PDT)
Received: from github-lowworker-0eea13f.ash1-iad.github.net (github-lowworker-0eea13f.ash1-iad.github.net [10.56.109.26]) by smtp.github.com (Postfix) with ESMTP id 4BAB866008C for <quic-issues@ietf.org>; Sun, 10 May 2020 17:04:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1589155495; bh=qy9zogxC3wNd6FfXfrzAueCSTIkMHjXzhLGNenRPI6s=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Cz7EACGPDccLRO2AkRVTjQttJJDxIio9KIhsgVWet040J9ly8k7jObx/YiIp2dNT2 rKER0qWIeMvotQdCtmMBanu3TxZ6pg1gtOHBWm2E/jbGU2MJFNZiIetcjlM7vVLs1t yWnd4/B3ufOj4m0iJ88tYs53nOSJbJVFW/fRlVIQ=
Date: Sun, 10 May 2020 17:04:55 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZXYZI74N7XMBFY2RN4YR32PEVBNHHCH4LVNY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3589/review/408794632@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3589@github.com>
References: <quicwg/base-drafts/pull/3589@github.com>
Subject: Re: [quicwg/base-drafts] Clarify text around preferred address (#3589)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5eb896a734f14_5ea13fedbe4cd95c451053"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/XzmMNGGtWhOl5IXcGq5xxeG3h1A>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 11 May 2020 00:04:59 -0000

@martinthomson commented on this pull request.



> @@ -1084,10 +1084,10 @@ Sending a RETIRE_CONNECTION_ID frame indicates that the connection ID will not
 be used again and requests that the peer replace it with a new connection ID
 using a NEW_CONNECTION_ID frame.
 
-As discussed in {{migration-linkability}}, endpoints limit the use of a
-connection ID to a single network path where possible. Endpoints SHOULD retire
-connection IDs when no longer actively using the network path on which the
-connection ID was used.
+As discussed in {{migration-linkability}}, endpoints MUST limit the use of a
+connection ID to packets sent from a single local address.  Endpoints SHOULD
+retire connection IDs when they are no longer actively using the network path on
+which the connection ID was used.

Perhaps the answer here is to say "endpoints limit the use of a connection ID to a single network path".  The point about NAT rebinding/inadvertent migration here is not relevant and somewhat distracting.  The reintroduction of the "MUST" is problematic as this implies a canonical requirement, but you can't really make that without adding the necessary context about NAT rebinding.

> @@ -2277,11 +2278,21 @@ linked by any other entity.
 At any time, endpoints MAY change the Destination Connection ID they send to a
 value that has not been used on another path.
 
-An endpoint MUST use a new connection ID if it initiates connection migration as
-described in {{initiating-migration}} or probes a new network path as described
-in {{probing}}.  An endpoint MUST use a new connection ID in response to a
-change in the address of a peer if the packet with the new peer address uses an
-active connection ID that has not been previously used by the peer.
+An endpoint MUST NOT reuse a connection ID when sending from more than one local
+address, for example when initiating connection migration as described in
+{{initiating-migration}} or when probing a new network path as described in
+{{probing}}.
+
+Similarly, an endpoint MUST NOT reuse a connection ID when sending to more than
+one destination address.  However, if an endpoint receives packets from a new
+source address with the same destination connection ID, it MAY continue to use
+the current connection ID with the new address.

How about:

> However, if a peer experiences NAT rebinding, an endpoint could receive packets from its peer using a new source address with the same destination connection ID.  If a peer is first to use a connection ID on a new network path and that connection ID was originally used on another network path, an endpoint MAY also use a connection ID that it used on the original network path.

That is much more wordy, but it might be clearer.  The point is to say that you don't reuse a connection ID unless your peer reuses first.

There is a wrinkle here in the case that an endpoint has multiple valid addresses (think preferred address).  In that case, we don't want to allow reuse as that implies a bunch of other things.  The fix there might be to add:

> This exception that allows the use of a connection ID on multiple network paths only applies when the remote address changes and the local address remains constant.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3589#discussion_r422718955