IETF Logo Mail Archive

Re: [quicwg/base-drafts] Do not reset pto_count on Initial ACKs (#3551)

Kazuho Oku <notifications@github.com> Tue, 31 March 2020 02:33 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C5C5F3A187D for <quic-issues@ietfa.amsl.com>; Mon, 30 Mar 2020 19:33:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.5
X-Spam-Level:
X-Spam-Status: No, score=-0.5 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=0.7, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id R2cud2wXPSEm for <quic-issues@ietfa.amsl.com>; Mon, 30 Mar 2020 19:33:17 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8CD6E3A1887 for <quic-issues@ietf.org>; Mon, 30 Mar 2020 19:33:17 -0700 (PDT)
Date: Mon, 30 Mar 2020 19:33:16 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1585621996; bh=nBdDHOXZV4zkAdxOp504Dpk2lVGBrpVHbBfh2FempbY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=SNuzoXy4qFENvWSzwQGRKgAFvKhVigx8wuiIheL0vtyRh6oUexSg9XnMxakwop5BL VWnc6ZqgFvzLGNCnEXAowThh2U9MRx97SPWSuSNHBIqXUA9815WN4vLon4zsLkw7vC LTjBNuPk57huK2fpaDMfKwNFdmbKRZgv27tJHT8Y=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK454PNATNEDK66T7JN4R2GOZEVBNHHCGKCD2A@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3551/review/384362512@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3551@github.com>
References: <quicwg/base-drafts/pull/3551@github.com>
Subject: Re: [quicwg/base-drafts] Do not reset pto_count on Initial ACKs (#3551)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e82abec6149e_492b3f9e31ecd95c131196"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Y15HU2OHFkxTubcvzpjuidzTOQs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Mar 2020 02:33:19 -0000

@kazuho commented on this pull request.



> @@ -1139,8 +1145,9 @@ OnAckReceived(ack, pn_space):
     OnPacketAcked(acked_packet.packet_number, pn_space)
 
   DetectLostPackets(pn_space)
-
-  pto_count = 0
+  // Reset pto_count, unless the client receives an Initial ACK
+  if (endpoint is server || pn_space != Initial)

Shouldn't we better invoke `PeerCompletedAddressValidation()`?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3551#pullrequestreview-384362512

v2.19.0 | Report a Bug | By Email