Re: [quicwg/base-drafts] Rework Key Update (#2237)

Martin Thomson <notifications@github.com> Wed, 13 February 2019 03:08 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 780FF1295D8 for <quic-issues@ietfa.amsl.com>; Tue, 12 Feb 2019 19:08:43 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.597
X-Spam-Level:
X-Spam-Status: No, score=-1.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f-OrOIgjhqGI for <quic-issues@ietfa.amsl.com>; Tue, 12 Feb 2019 19:08:41 -0800 (PST)
Received: from o8.sgmail.github.com (o8.sgmail.github.com [167.89.101.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AAA0A1277D2 for <quic-issues@ietf.org>; Tue, 12 Feb 2019 19:08:41 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=OtaHh0MkIldZsOX9KsqQhDUFrtw=; b=fJ39SIUiYchEUfdO vmXLyO4rUntsnniMKHo/Vic9z0mPeK+j5crdUSPG3qoSSC35IHOPP6Gid7k6tyXh l6m6t2TA42mMMvRIwNyYSn3CyN/FKAmUnfdmD5cV9f/MbylHstv4r0hcIW5kkWQB tLHd9Wm+Mz/uIgi7lTD3Brd4XQ4=
Received: by filter0906p1las1.sendgrid.net with SMTP id filter0906p1las1-4890-5C638A38-E 2019-02-13 03:08:40.618737786 +0000 UTC m=+70709.385908731
Received: from github-lowworker-dc5ea3e.cp1-iad.github.net (unknown [192.30.252.45]) by ismtpd0035p1iad2.sendgrid.net (SG) with ESMTP id 5GRePIsET-2vYjTWlQWF2Q for <quic-issues@ietf.org>; Wed, 13 Feb 2019 03:08:40.538 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-dc5ea3e.cp1-iad.github.net (Postfix) with ESMTP id 7A4BA2609CF for <quic-issues@ietf.org>; Tue, 12 Feb 2019 19:08:40 -0800 (PST)
Date: Wed, 13 Feb 2019 03:08:40 +0000
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab08316ecc8efbe2ba00c1638a07d1b00e6a40410f92cf00000001187b4c3892a169ce1770e975@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2237/review/203012421@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2237@github.com>
References: <quicwg/base-drafts/pull/2237@github.com>
Subject: Re: [quicwg/base-drafts] Rework Key Update (#2237)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c638a386e3f9_dd23ffc6e4d45b891861"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak37fsWpkW1mrHS+W1Pt/2yy+2/a7V7P/ZXIR7 BYi0bNJI08Jb/CrWRrmCSaQV0gl8ngqDNZHeNehLlthZwXkpb9+xfvrSFQ47ZMv4uxvYWaNsuD8t7l F/H++A/F2caSAxWIxc+IJviOc9nw+3iOWVFyQsBlwXR0Q6PVxIXLX2wM0coPbYAMxyaPtrYmmGm26o 4=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Y6Q6aizJMvUNt3J-7ps_EDcXA_E>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Feb 2019 03:08:44 -0000

martinthomson commented on this pull request.



> @@ -5012,6 +5020,44 @@ Reason Phrase:
   This SHOULD be a UTF-8 encoded string {{!RFC3629}}.
 
 
+## KEYS_READY Frame {#frame-keys-ready}
+
+An endpoint sends a KEYS_READY frame (type=0x1e) to signal that it has installed
+keys for reading and writing packets.  Receipt of this frame in a packet
+indicates that all earlier keys can be safely discarded.

Note the receiving only is a hangup from before I added the bit about delaying transmission of the frame in order to limit the number of active keys.  If you don't have that, receipt is sufficient because receiving the frame always implies that you need to send a matching frame.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2237#discussion_r256233126