IETF Logo Mail Archive

Re: [quicwg/base-drafts] Split PTO calculation into a dedicated method (#3681)

ianswett <notifications@github.com> Thu, 21 May 2020 14:51 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 51E733A0AAC for <quic-issues@ietfa.amsl.com>; Thu, 21 May 2020 07:51:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.554
X-Spam-Level:
X-Spam-Status: No, score=-1.554 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DZ94NYhPqq4g for <quic-issues@ietfa.amsl.com>; Thu, 21 May 2020 07:50:47 -0700 (PDT)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BE7513A09DE for <quic-issues@ietf.org>; Thu, 21 May 2020 07:50:47 -0700 (PDT)
Received: from github-lowworker-45eca55.ac4-iad.github.net (github-lowworker-45eca55.ac4-iad.github.net [10.52.25.70]) by smtp.github.com (Postfix) with ESMTP id A25A08C0026 for <quic-issues@ietf.org>; Thu, 21 May 2020 07:50:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1590072646; bh=sLOTME7cDh7l2WqyQnQbvkWZYFIscjHiyHBw5bJriac=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=wN5BgKtB7TAdOWL7IDJmDAb1ABVKEFFE6uK7ElIqLsaUr9rfYLNE5yW0q1KamT9dI WjT3lFrA8TNC/sJ+0i8NxmtrN3jdIJ8YVEXxLw7Szpy31/FKusvzcxjPruld6qeDi9 yu2L/0GYkGIPtH3xox9+9F+8G0JvP4wWr5pFQVLo=
Date: Thu, 21 May 2020 07:50:46 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5SQUGYXUM5OFCVOYF42J3ENEVBNHHCKEI7XY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3681/review/416215165@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3681@github.com>
References: <quicwg/base-drafts/pull/3681@github.com>
Subject: Re: [quicwg/base-drafts] Split PTO calculation into a dedicated method (#3681)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ec6954691548_4c213ff7120cd96c1090d7"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Y6Tp6O26p71MUcNdbhOpdQvpZFY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 21 May 2020 14:51:48 -0000

@ianswett commented on this pull request.



>        space = pn_space
   return time, space
 
+GetPtoTimeAndSpace():
+  duration = smoothed_rtt +
+      max(4 * rttvar, kGranularity) * (2 ^ pto_count)
+  # Arm PTO from now when there are no inflight packets
+  if (no in-flight packets):
+    return now() + duration, Initial
+  timeout = infinite
+  pn_space = Initial

Sg, changed to pto_timeout and pto_space.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3681#discussion_r428700548

v2.23.0 | Report a Bug | By Email