IETF Logo Mail Archive

Re: [quicwg/base-drafts] Reword Immediate ACK Recommendation (#2424)

ianswett <notifications@github.com> Thu, 07 February 2019 21:28 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 854BC129A85 for <quic-issues@ietfa.amsl.com>; Thu, 7 Feb 2019 13:28:10 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.597
X-Spam-Level:
X-Spam-Status: No, score=-1.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bRUg5bnvVtLg for <quic-issues@ietfa.amsl.com>; Thu, 7 Feb 2019 13:28:08 -0800 (PST)
Received: from o9.sgmail.github.com (o9.sgmail.github.com [167.89.101.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 27FE412D4E8 for <quic-issues@ietf.org>; Thu, 7 Feb 2019 13:28:08 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=bPPeGeKeEyoyUauYW68RMRZkayM=; b=o1Vow+/JAmY6IcgN MxU7DHwsitmTjkBbViJOxcc+cytcOzWmRKHdA83s2CFQPwClynWK5fMKeiyhWc+J aZbvvsR3Ch5wawYW9inSOjyT/19ryhXj3NyC8tC7eniXSA/8ZKacNUg5ijGQp/E6 o26mhRRWKl7QQhb0vvKzb/W+TLw=
Received: by filter1539p1mdw1.sendgrid.net with SMTP id filter1539p1mdw1-17017-5C5CA2E7-1 2019-02-07 21:28:07.03373072 +0000 UTC m=+163758.905964948
Received: from github-lowworker-1c220e1.cp1-iad.github.net (unknown [192.30.252.44]) by ismtpd0005p1iad1.sendgrid.net (SG) with ESMTP id FWwurvQHSrabigD5xYLmjw for <quic-issues@ietf.org>; Thu, 07 Feb 2019 21:28:06.995 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-1c220e1.cp1-iad.github.net (Postfix) with ESMTP id EEDA3160586 for <quic-issues@ietf.org>; Thu, 7 Feb 2019 13:28:06 -0800 (PST)
Date: Thu, 07 Feb 2019 21:28:07 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab24a18ee41073be05f73af29371603eac3ba244fb92cf00000001187464e692a169ce1842c3b7@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2424/review/201333004@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2424@github.com>
References: <quicwg/base-drafts/pull/2424@github.com>
Subject: Re: [quicwg/base-drafts] Reword Immediate ACK Recommendation (#2424)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c5ca2e6e9b9a_43cd3f82168d45b43337a4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0lDyZqf1C4zAEIJbvTEe+K7QE6/GwvdAwqG+ aMuq4yR++asR9drY6VVfLaeLrPAbQwi77WrKFBoNRgO1LI2F/VB8yFqtHpgJ0pL6ADZkUGySbSk12G AmQ0t1azYZiT3HIeW1X7JWf+BrHZ2yW0GSQxxRY+1Z3RKi8+QvfOYmDTGw==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Y70QTNFG88iewDU3eerWc0o7t-c>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Feb 2019 21:28:11 -0000

ianswett commented on this pull request.



> @@ -134,6 +134,11 @@ Crypto Packets:
 
 : Packets containing CRYPTO data sent in Initial or Handshake
   packets.
+  
+Out-of-order Packets:
+
+: Packets that do not increase the largest received packet number for its
+cryptographic context by exactly one.

My suggestion should have been "Packets arrive out of order when later packets are lost or delayed.", but Martin's suggestion is slightly better because it drops 'later', which is unnecessary.

The intent was as a replacement for Martin's suggestion, in addition to the first sentence you have.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2424#discussion_r254875673

v2.23.0 | Report a Bug | By Email