Re: [quicwg/base-drafts] Strengthen 2119 language around tokens. (#2124)
Martin Thomson <notifications@github.com> Thu, 13 December 2018 04:00 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2D53F128CFD for <quic-issues@ietfa.amsl.com>; Wed, 12 Dec 2018 20:00:10 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.056
X-Spam-Level:
X-Spam-Status: No, score=-8.056 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id D4ZhlelZfqye for <quic-issues@ietfa.amsl.com>; Wed, 12 Dec 2018 20:00:08 -0800 (PST)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4A380128DFD for <quic-issues@ietf.org>; Wed, 12 Dec 2018 20:00:08 -0800 (PST)
Date: Wed, 12 Dec 2018 20:00:07 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1544673607; bh=RWFaGmvt9SapBGOkKigRri62dLYc1vwqPT858LKdGIk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=cu5aBj3320YlogA6AKcZx5LPiHCamsO6UF3bOej1pFRdR1qSLuNk/E+PL6WDu5SWU Y+Mjd2+vLMhG+qy1ujSTP1qHuZ/alVzQsHmjL4nD0v+UXIfmmfCkOh8FTRgLPm0Mdm R41Zsp1CbiypULXPzVwAg2hIivQXKWhGshCvCmQQ=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab769687e3771b33b4a055e556ce6f14a4a2724d2192cf0000000118299b4792a169ce1742d764@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2124/review/184494299@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2124@github.com>
References: <quicwg/base-drafts/pull/2124@github.com>
Subject: Re: [quicwg/base-drafts] Strengthen 2119 language around tokens. (#2124)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c11d947762ba_2bd53fcee6cd45c0888a8"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/YAINbBe108qYGh-yV8SN-jIq8Gs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Dec 2018 04:00:10 -0000
martinthomson commented on this pull request. > @@ -1610,7 +1610,7 @@ A resumption token SHOULD be constructed to be easily distinguishable from tokens that are sent in Retry packets as they are carried in the same field. If the client has a token received in a NEW_TOKEN frame on a previous connection -to what it believes to be the same server, it can include that value in the +to what it believes to be the same server, it SHOULD include that value in the If we go with SHOULD, then we need to address the reasons that an endpoint might diverge from that. I realize that it's a cop-out, but "can" is so much easier. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2124#discussion_r241265846
- [quicwg/base-drafts] Strengthen 2119 language aro… ekr
- Re: [quicwg/base-drafts] Strengthen 2119 language… MikkelFJ
- Re: [quicwg/base-drafts] Strengthen 2119 language… ekr
- Re: [quicwg/base-drafts] Strengthen 2119 language… Mike Bishop
- Re: [quicwg/base-drafts] Strengthen 2119 language… Martin Thomson
- Re: [quicwg/base-drafts] Strengthen 2119 language… janaiyengar
- Re: [quicwg/base-drafts] Strengthen 2119 language… Martin Thomson
- Re: [quicwg/base-drafts] Strengthen 2119 language… Martin Thomson
- Re: [quicwg/base-drafts] Strengthen 2119 language… Martin Thomson