Date: Wed, 12 Dec 2018 20:00:07 -0800
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4ab769687e3771b33b4a055e556ce6f14a4a2724d2192cf0000000118299b4792a169ce1742d764@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2124/review/184494299@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2124@github.com>
References: <quicwg/base-drafts/pull/2124@github.com>
Subject: Re: [quicwg/base-drafts] Strengthen 2119 language around tokens.
 (#2124)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5c11d947762ba_2bd53fcee6cd45c0888a8";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/YAINbBe108qYGh-yV8SN-jIq8Gs>


----==_mimepart_5c11d947762ba_2bd53fcee6cd45c0888a8
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

martinthomson commented on this pull request.



> @@ -1610,7 +1610,7 @@ A resumption token SHOULD be constructed to be easily distinguishable from
 tokens that are sent in Retry packets as they are carried in the same field.
 
 If the client has a token received in a NEW_TOKEN frame on a previous connection
-to what it believes to be the same server, it can include that value in the
+to what it believes to be the same server, it SHOULD include that value in the

If we go with SHOULD, then we need to address the reasons that an endpoint might diverge from that.  I realize that it's a cop-out, but "can" is so much easier.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2124#discussion_r241265846
----==_mimepart_5c11d947762ba_2bd53fcee6cd45c0888a8
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@martinthomson</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/2124#discussion_r241265846">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; @@ -1610,7 +1610,7 @@ A resumption token SHOULD be constructed to be easily distinguishable from
 tokens that are sent in Retry packets as they are carried in the same field.
 
 If the client has a token received in a NEW_TOKEN frame on a previous connection
-to what it believes to be the same server, it can include that value in the
+to what it believes to be the same server, it SHOULD include that value in the
</pre>
<p>If we go with SHOULD, then we need to address the reasons that an endpoint might diverge from that.  I realize that it's a cop-out, but "can" is so much easier.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/2124#discussion_r241265846">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkq6spPiZY_JsvZdfbq53Mg82vEXo_ks5u4dDHgaJpZM4ZPkzt">mute the thread</a>.<img src="https://github.com/notifications/beacon/AWbkqxJoXeyD3fGzpDv9NQmxm-AcdEWHks5u4dDHgaJpZM4ZPkzt.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@martinthomson commented on #2124"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/2124#discussion_r241265846"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/2124#discussion_r241265846",
"url": "https://github.com/quicwg/base-drafts/pull/2124#discussion_r241265846",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5c11d947762ba_2bd53fcee6cd45c0888a8--