Re: [quicwg/base-drafts] Clarify which packet losses may be ignored (#3450)

Martin Thomson <notifications@github.com> Thu, 13 February 2020 23:28 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 944D71207FD for <quic-issues@ietfa.amsl.com>; Thu, 13 Feb 2020 15:28:29 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ArekIt-GGgQB for <quic-issues@ietfa.amsl.com>; Thu, 13 Feb 2020 15:28:26 -0800 (PST)
Received: from out-11.smtp.github.com (out-11.smtp.github.com [192.30.254.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B1601120289 for <quic-issues@ietf.org>; Thu, 13 Feb 2020 15:28:26 -0800 (PST)
Received: from github-lowworker-6b40fdd.va3-iad.github.net (github-lowworker-6b40fdd.va3-iad.github.net [10.48.16.64]) by smtp.github.com (Postfix) with ESMTP id 4D31626171C for <quic-issues@ietf.org>; Thu, 13 Feb 2020 15:28:26 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1581636506; bh=NBy+iJPMZepnlc3yhgSmeErskixp9BO3KZVZhwGLYV0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=XiEp8vTHsqy5xW1amn35wPnt5xIs6WyAAnpvwXvH0dAdEzaYdbE7YvidEGBOFmpYz t4qRoenBeZSxe5yRxPSuj7kjlO57coU6vidAmGDYubsQ/3qOqUua1Kv4+xT3dZu/zU I3ZcbCK3ANf7eQiiMBUcnVXF9gANcsvxwiBIEuMk=
Date: Thu, 13 Feb 2020 15:28:25 -0800
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5BDKZPOHZDCUE5LOV4KMHBTEVBNHHCDFAESA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3450/review/358624093@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3450@github.com>
References: <quicwg/base-drafts/pull/3450@github.com>
Subject: Re: [quicwg/base-drafts] Clarify which packet losses may be ignored (#3450)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e45db99f06a2_437b3fee434cd96868549"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/YFttoQkf8fJdfOvlj9Yb51xIrgU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Feb 2020 23:28:29 -0000

martinthomson approved this pull request.

I might have to put in a lint for HTAB...

> @@ -690,12 +690,14 @@ losses or increases in the ECN-CE counter.
 
 ## Ignoring Loss of Undecryptable Packets	
 
-During the handshake, some packet protection keys might not be	
-available when a packet arrives. In particular, Handshake and 0-RTT packets	
-cannot be processed until the Initial packets arrive, and 1-RTT packets	
-cannot be processed until the handshake completes.  Endpoints MAY	
-ignore the loss of Handshake, 0-RTT, and 1-RTT packets that might arrive before	
-the peer has packet protection keys to process those packets.	
+During the handshake, some packet protection keys might not be available when
+a packet arrives and the receiver can choose to drop the packet. In particular,
+Handshake and 0-RTT packets cannot be processed until the Initial packets
+arrive, and 1-RTT packets	cannot be processed until the handshake completes.

An errant tab here.
```suggestion
arrive and 1-RTT packets cannot be processed until the handshake completes.
```

> @@ -690,12 +690,14 @@ losses or increases in the ECN-CE counter.
 
 ## Ignoring Loss of Undecryptable Packets	
 
-During the handshake, some packet protection keys might not be	
-available when a packet arrives. In particular, Handshake and 0-RTT packets	
-cannot be processed until the Initial packets arrive, and 1-RTT packets	
-cannot be processed until the handshake completes.  Endpoints MAY	
-ignore the loss of Handshake, 0-RTT, and 1-RTT packets that might arrive before	
-the peer has packet protection keys to process those packets.	
+During the handshake, some packet protection keys might not be available when
+a packet arrives and the receiver can choose to drop the packet. In particular,
+Handshake and 0-RTT packets cannot be processed until the Initial packets
+arrive, and 1-RTT packets	cannot be processed until the handshake completes.
+Endpoints MAY	ignore the loss of Handshake, 0-RTT, and 1-RTT packets that might

and here
```suggestion
Endpoints MAY ignore the loss of Handshake, 0-RTT, and 1-RTT packets that might
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3450#pullrequestreview-358624093