Re: [quicwg/base-drafts] Error for frames in the wrong packet (#3859)

Marten Seemann <notifications@github.com> Wed, 08 July 2020 05:13 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DB2733A082A for <quic-issues@ietfa.amsl.com>; Tue, 7 Jul 2020 22:13:22 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.555
X-Spam-Level:
X-Spam-Status: No, score=-1.555 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ybLocn8m8JEk for <quic-issues@ietfa.amsl.com>; Tue, 7 Jul 2020 22:13:21 -0700 (PDT)
Received: from out-14.smtp.github.com (out-14.smtp.github.com [192.30.254.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A5A953A0828 for <quic-issues@ietf.org>; Tue, 7 Jul 2020 22:13:21 -0700 (PDT)
Received: from github-lowworker-a27607f.ash1-iad.github.net (github-lowworker-a27607f.ash1-iad.github.net [10.56.18.61]) by smtp.github.com (Postfix) with ESMTP id E13A51212A6 for <quic-issues@ietf.org>; Tue, 7 Jul 2020 22:13:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1594185200; bh=ebvZzy5gCUJLCFSnKOBwvu3znDkWlyD+ZEqsTgelkqk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=LcnDJRtLMRJjHjkSKd1ISjbyUYYcWMxSiD1r65K7mqBqVo5R3KEf2g7mTujt2FZ1i EKEFusus3FlO+VDnDx8tasfQ+cB/vOrVtoshJpHgLMp3PZrka4mkVrm6jRluW4pki6 c91ON5gK2hLeq2sHrSbfpGkJQMVz3n0bYVxML8sM=
Date: Tue, 07 Jul 2020 22:13:20 -0700
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4HQNMBQIFMHLNUMOV5CE3PBEVBNHHCN23QG4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3859/review/444417773@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3859@github.com>
References: <quicwg/base-drafts/pull/3859@github.com>
Subject: Re: [quicwg/base-drafts] Error for frames in the wrong packet (#3859)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f0555f09b583_5b953f91ad4cd96096124"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/YHXDVoznXK7oTz78ePbEoQo4FJ0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Jul 2020 05:13:23 -0000

@marten-seemann commented on this pull request.



> @@ -3354,7 +3354,9 @@ ih:
   packets.
 
 Section 4 of {{QUIC-TLS}} provides more detail about these restrictions.  Note
-that all frames can appear in 1-RTT packets.
+that all frames can appear in 1-RTT packets.  An endpoint MUST treat receipt of
+a frame in a packet type that is not permitted as a connection error of type
+PROTOCOL_VIOLATION.

Depends on what your definition of "context" is. If it is "the bytes that this frame is composed of", then no. If you include the encryption level you received those bytes with, then "yes". You might want to do that, because the encryption level is not connection-level state.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3859#discussion_r451287053