IETF Logo Mail Archive

Re: [quicwg/base-drafts] Proposal for adding ECN support to QUIC. (#1372)

Magnus Westerlund <notifications@github.com> Tue, 12 June 2018 09:41 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C678813112B for <quic-issues@ietfa.amsl.com>; Tue, 12 Jun 2018 02:41:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.008
X-Spam-Level:
X-Spam-Status: No, score=-3.008 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zDHtLIrRtwDq for <quic-issues@ietfa.amsl.com>; Tue, 12 Jun 2018 02:41:10 -0700 (PDT)
Received: from o11.sgmail.github.com (o11.sgmail.github.com [167.89.101.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2B57A131130 for <quic-issues@ietf.org>; Tue, 12 Jun 2018 02:41:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=uXcWZK3ri78Frc0zgLkugxwgMFI=; b=a9MN5k7xSMYegDmD A/40BNNj8LXNgTOPOiz1SZZ+DNlp6v8VtXz2Hfnn7yvwhEfsVPz/1Dqpwy3BaleS 8gKuZG3lWzGHcPKwe7XcoR8RzqJieUEg09ucYskp7q6K5xK5gV7md+yZcut6XC3Q Oh8rdmYpcHlbsSBIHcxKuOZcVik=
Received: by filter1738p1mdw1.sendgrid.net with SMTP id filter1738p1mdw1-6990-5B1F9534-F 2018-06-12 09:41:08.360791258 +0000 UTC
Received: from github-lowworker-baaab27.cp1-iad.github.net (unknown [192.30.252.33]) by ismtpd0004p1iad1.sendgrid.net (SG) with ESMTP id L5Y0AKYgRMqiYhFPbaMkmQ for <quic-issues@ietf.org>; Tue, 12 Jun 2018 09:41:08.326 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-baaab27.cp1-iad.github.net (Postfix) with ESMTP id 4C40880313 for <quic-issues@ietf.org>; Tue, 12 Jun 2018 02:41:08 -0700 (PDT)
Date: Tue, 12 Jun 2018 09:41:08 +0000
From: Magnus Westerlund <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab2688d2407e0b3106395e653c0f16dc1d463bc73492cf000000011737573492a169ce13656182@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1372/review/127889461@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1372@github.com>
References: <quicwg/base-drafts/pull/1372@github.com>
Subject: Re: [quicwg/base-drafts] Proposal for adding ECN support to QUIC. (#1372)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b1f95344a802_5dbc2ac927400f54882790"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: gloinul
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1HE/NjVuLSKOsfVN7lHL8JEzJiJj+YNzanTD qLO2DoGI2Om14cW04q+ozCDlKncwGjtRKlZiB/I6UEM965nhJSiGO0vQvC6eTAPpWmU9GGcmmkhlnx 3dONGeRGjW+xWPwGprCuogTM7OcpwSM2CAkC7aTPOWLEryKL44nD913eNpWrxN8F0dOgg62uiUn63p w=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/YIDeg0eRXNOVfx5Mrp5F5EUzwYg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Jun 2018 09:41:14 -0000

gloinul commented on this pull request.



> @@ -2816,6 +2960,10 @@ ACK Block (repeated):
 
 ### Sending ACK Frames
 
+ACK Frames MAY be sent when all packets to be acknowledge had an IP header with

Okay, I removed this paragraph, and moved the MAY statement to the ACK_ECN frame, the MUST statement was already present. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1372#discussion_r194675822

v2.29.0 | Report a Bug | By Email | System Status