[quicwg/base-drafts] Pseudocode fix: Data should be sent on loss-threshold timer (#2604)

Jana Iyengar <notifications@github.com> Wed, 10 April 2019 06:36 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4A52012007A for <quic-issues@ietfa.amsl.com>; Tue, 9 Apr 2019 23:36:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.597
X-Spam-Level:
X-Spam-Status: No, score=-6.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id doi-d5BA-hoJ for <quic-issues@ietfa.amsl.com>; Tue, 9 Apr 2019 23:36:14 -0700 (PDT)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 28425120071 for <quic-issues@ietf.org>; Tue, 9 Apr 2019 23:36:14 -0700 (PDT)
Date: Tue, 09 Apr 2019 23:36:12 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1554878172; bh=ohL5RoN9F5XSxSwtDHSAY3He2o8QPE2QnH5rYh2GVWI=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=pT5qhK7JhUDpI9wjVRltRp7RakRwcFaqnO9/IQshUsWwTVqsqqVWCXFByYHVjkxsp cos9ukSXwwlO//8ZSq9XObXg9PxUYZ9kJ7R4IAtNrLx3wIPNkOdF5N7i0dDMhhUkPp ZKExYKLQWHgCkKAM+9QyEietAINcbYlIfseLXBZ4=
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abfbb2d7d025f63d35801fc71b3806e2849d108c2c92cebabac15c92a169ce19b58a1d@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2604@github.com>
Subject: [quicwg/base-drafts] Pseudocode fix: Data should be sent on loss-threshold timer (#2604)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cad8edcd7422_2a233f7e4a0d45b41391e4"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/YIF7Smxv1uurUu2ovUimue0TIrc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Apr 2019 06:36:16 -0000

(@larseggert : Thanks for catching this)

Currently, in OnLossDetectionTimeout(), we detect losses but do not sent anything on time threshold loss detection.  This means that SetLossDetectionTimer() that is called later in the function does not set a timer because inflight can be 0 (if all inflight is marked lost).

This is an oversight, since clearly we send rtxs when we mark packets as lost, and in the case of threshold detection, we send as much as the cwnd allows.

My proposal is to add the last two lines below
if (loss_time != 0):
    // Time threshold loss Detection
    DetectLostPackets(pn_space)
    SendOnePacketWithRetransmittedData()
    SendDataAsCwndAllows()

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2604