Re: [quicwg/base-drafts] Consider simplifying Packet Number Encryption (#1575)

David Schinazi <notifications@github.com> Tue, 17 July 2018 18:41 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5B13F130E44 for <quic-issues@ietfa.amsl.com>; Tue, 17 Jul 2018 11:41:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7_DAwSSju6RE for <quic-issues@ietfa.amsl.com>; Tue, 17 Jul 2018 11:41:36 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0C7D9130E2A for <quic-issues@ietf.org>; Tue, 17 Jul 2018 11:41:36 -0700 (PDT)
Date: Tue, 17 Jul 2018 11:41:35 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1531852895; bh=ochkFIehu1Sk18DFjuDV/i5KgAM2GC3/R1VYeCWo8e0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=H3CiFrnqAG/Q7lqoOsHTMrkApoHjoy2jS83YvPQ3oag5vv8BiOJwY8b6MrFqkQsin er+/cuEjhyQ5a/p6rBE/9b/PlD8BntixrX3zrDB/XGOQTpFXh5VZMsFD5cn2BcL7UA jKIhd/M8/z5WIx4d7qUF+9U6gSlgx+0JtbfNoJao=
From: David Schinazi <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abcd74c5e312edccdbb9d8b4531cc5a0487e1ebbe392cf000000011765fa5f92a169ce14620d9d@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1575/405685938@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1575@github.com>
References: <quicwg/base-drafts/issues/1575@github.com>
Subject: Re: [quicwg/base-drafts] Consider simplifying Packet Number Encryption (#1575)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b4e385f65b0c_5e842b2353ef2f58119781"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: DavidSchinazi
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/YIYYIVD8C6d575jY8H77pjc5SYk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Jul 2018 18:41:38 -0000

I agree that this isn't necessary - I'm just wondering if this proposal could make implementations simpler and safer.

Proposal: always encrypt four bytes [pn_offset, pn_offset + 3] and always have the sample start at pn_offset + 4. If the sample were to overflow the payload + tag (which only happens if you use 128-bit AES and have pn_len + payload_len < 4), you just pad the sample with zeroes. In the worst case scenario the sample contains two bytes of zero but you still have a 128bit secret key. Is that unacceptable?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1575#issuecomment-405685938